Florian Fainelli <f.faine...@gmail.com> writes: > - phy_mode = of_get_phy_mode(ds->dst->cpu_dp->dn); > + phy_mode = of_get_phy_mode(ds->ports[QCA8K_CPU_PORT].dn);
Is it necessary to use QCA8K_CPU_PORT? > +static inline struct dsa_port *dsa_ds_get_cpu_dp(struct dsa_switch *ds) > +{ > + return &ds->ports[fls(ds->cpu_port_mask) - 1]; > +} Wouldn't it be better to return the CPU port for a given port? Something like return ds->ports[port].cpu_dp, so that we ease the introduction of multiple CPU port a bit more? Thanks, Vivien