Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

2016-04-06 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> >> mutex_lock(&ps->smi_mutex); >> >> - ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state); >> >> + if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state)) >> >> + netdev_warn(ds->ports[port], "cannot load address\n"); >> >

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

2016-04-06 Thread Andrew Lunn
On Tue, Apr 05, 2016 at 11:14:54PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > >>mutex_lock(&ps->smi_mutex); > >> - ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state); > >> + if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state)) > >

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

2016-04-05 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> mutex_lock(&ps->smi_mutex); >> -ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state); >> +if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state)) >> +netdev_warn(ds->ports[port], "cannot load address\n"); > >

Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void

2016-04-05 Thread Andrew Lunn
On Tue, Apr 05, 2016 at 11:24:34AM -0400, Vivien Didelot wrote: > The switchdev design implies that a software error should not happen in > the commit phase since it must have been previously reported in the > prepare phase. If an hardware error occurs during the commit phase, > there is nothing sw