Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-11 Thread Jamal Hadi Salim
On 2021-04-09 9:43 a.m., Petr Machata wrote: Jamal Hadi Salim writes: Does the spectrum not support multiple actions? e.g with a policy like: match blah action trap action drop skip_sw Trap drops implicitly. We need a "trap, but don't drop". Expressed in terms of existing actions it wou

Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-09 Thread Petr Machata
Jamal Hadi Salim writes: > On 2021-04-09 7:03 a.m., Petr Machata wrote: >> Jamal Hadi Salim writes: >> >>> I am concerned about adding new opcodes which only make sense if you >>> offload (or make sense only if you are running in s/w). >>> >>> Those opcodes are intended to be generic abstract

Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-09 Thread Jamal Hadi Salim
On 2021-04-09 7:03 a.m., Petr Machata wrote: Jamal Hadi Salim writes: I am concerned about adding new opcodes which only make sense if you offload (or make sense only if you are running in s/w). Those opcodes are intended to be generic abstractions so the dispatcher can decide what to do nex

Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-09 Thread Jamal Hadi Salim
On 2021-04-08 5:25 p.m., Jakub Kicinski wrote: On Thu, 8 Apr 2021 10:05:07 -0400 Jamal Hadi Salim wrote: On 2021-04-08 9:38 a.m., Petr Machata wrote: The TC action "trap" is used to instruct the HW datapath to drop the matched packet and transfer it for processing in the SW pipeline. If instead

Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-09 Thread Petr Machata
Jamal Hadi Salim writes: > I am concerned about adding new opcodes which only make sense if you > offload (or make sense only if you are running in s/w). > > Those opcodes are intended to be generic abstractions so the dispatcher > can decide what to do next. Adding things that are specific onl

Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-08 Thread Jakub Kicinski
On Thu, 8 Apr 2021 10:05:07 -0400 Jamal Hadi Salim wrote: > On 2021-04-08 9:38 a.m., Petr Machata wrote: > > The TC action "trap" is used to instruct the HW datapath to drop the > > matched packet and transfer it for processing in the SW pipeline. If > > instead it is desirable to forward the packe

Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-08 Thread Jamal Hadi Salim
Hi Petr, On 2021-04-08 9:38 a.m., Petr Machata wrote: The TC action "trap" is used to instruct the HW datapath to drop the matched packet and transfer it for processing in the SW pipeline. If instead it is desirable to forward the packet and transferring a _copy_ to the SW pipeline, there is no