Re: [PATCH net-next 09/12] ionic: add and enable tx and rx timestamp handling

2021-04-06 Thread Richard Cochran
On Tue, Apr 06, 2021 at 04:06:09PM -0700, Shannon Nelson wrote: > Interesting... I doubt that our particular MAC and PHY will ever be > separate, but it makes sense to watch for this in the general case. I've got > an update coming for this. Even if your HW can never support stacked MAC/PHY HW tim

Re: [PATCH net-next 09/12] ionic: add and enable tx and rx timestamp handling

2021-04-06 Thread Shannon Nelson
On 4/5/21 11:20 AM, Richard Cochran wrote: On Mon, Apr 05, 2021 at 09:28:44AM -0700, Shannon Nelson wrote: On 4/4/21 4:41 PM, Richard Cochran wrote: On Thu, Apr 01, 2021 at 10:56:07AM -0700, Shannon Nelson wrote: @@ -1150,6 +1232,10 @@ netdev_tx_t ionic_start_xmit(struct sk_buff *skb, struct

Re: [PATCH net-next 09/12] ionic: add and enable tx and rx timestamp handling

2021-04-05 Thread Richard Cochran
On Mon, Apr 05, 2021 at 09:28:44AM -0700, Shannon Nelson wrote: > On 4/4/21 4:41 PM, Richard Cochran wrote: > > On Thu, Apr 01, 2021 at 10:56:07AM -0700, Shannon Nelson wrote: > > > > > @@ -1150,6 +1232,10 @@ netdev_tx_t ionic_start_xmit(struct sk_buff *skb, > > > struct net_device *netdev) > > >

Re: [PATCH net-next 09/12] ionic: add and enable tx and rx timestamp handling

2021-04-05 Thread Shannon Nelson
On 4/4/21 4:41 PM, Richard Cochran wrote: On Thu, Apr 01, 2021 at 10:56:07AM -0700, Shannon Nelson wrote: @@ -1150,6 +1232,10 @@ netdev_tx_t ionic_start_xmit(struct sk_buff *skb, struct net_device *netdev) return NETDEV_TX_OK; } + if (unlikely(skb_shinfo(skb)->tx_fla

Re: [PATCH net-next 09/12] ionic: add and enable tx and rx timestamp handling

2021-04-04 Thread Richard Cochran
On Thu, Apr 01, 2021 at 10:56:07AM -0700, Shannon Nelson wrote: > @@ -1150,6 +1232,10 @@ netdev_tx_t ionic_start_xmit(struct sk_buff *skb, > struct net_device *netdev) > return NETDEV_TX_OK; > } > > + if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) > +