Re: [PATCH net-next 09/12] ionic: add and enable tx and rx timestamp handling

[Richard Cochran]

On Thu, Apr 01, 2021 at 10:56:07AM -0700, Shannon Nelson wrote:

> @@ -1150,6 +1232,10 @@ netdev_tx_t ionic_start_xmit(struct sk_buff *skb, 
> struct net_device *netdev)
>               return NETDEV_TX_OK;
>       }
>  
> +     if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP))
> +             if (lif->hwstamp_txq)
> +                     return ionic_start_hwstamp_xmit(skb, netdev);

The check for SKBTX_HW_TSTAMP and hwstamp_txq is good, but I didn't
see hwstamp_txq getting cleared in ionic_lif_hwstamp_set() when the
user turns off Tx time stamping via the SIOCSHWTSTAMP ioctl.

In addition, the code should set

        skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;

once the above tests pass.

Thanks,
Richard