Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread John Fastabend
On 16-06-30 08:53 AM, Jiri Pirko wrote: > Thu, Jun 30, 2016 at 05:40:57PM CEST, john.fastab...@gmail.com wrote: >> On 16-06-30 03:52 AM, Jiri Pirko wrote: >>> Thu, Jun 30, 2016 at 09:57:21AM CEST, john.fastab...@gmail.com wrote: On 16-06-30 12:41 AM, Jiri Pirko wrote: > Thu, Jun 30, 2016 a

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread Jiri Pirko
Thu, Jun 30, 2016 at 05:40:57PM CEST, john.fastab...@gmail.com wrote: >On 16-06-30 03:52 AM, Jiri Pirko wrote: >> Thu, Jun 30, 2016 at 09:57:21AM CEST, john.fastab...@gmail.com wrote: >>> On 16-06-30 12:41 AM, Jiri Pirko wrote: Thu, Jun 30, 2016 at 09:13:55AM CEST, sridhar.samudr...@intel.com

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread John Fastabend
On 16-06-30 03:52 AM, Jiri Pirko wrote: > Thu, Jun 30, 2016 at 09:57:21AM CEST, john.fastab...@gmail.com wrote: >> On 16-06-30 12:41 AM, Jiri Pirko wrote: >>> Thu, Jun 30, 2016 at 09:13:55AM CEST, sridhar.samudr...@intel.com wrote: On 6/29/2016 11:25 PM, Jiri Pirko wrote: > Thu,

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread Or Gerlitz
On Thu, Jun 30, 2016 at 1:52 PM, Jiri Pirko wrote: > Why not to have 2 modes: > 1) lagacy - the current solution, blackbox eswitch, undefined behaviour > 2) switchdev - with representors, all features possible as on physical > switches, whitebox eswitch configured using standard tools? yep, thi

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread Jiri Pirko
Thu, Jun 30, 2016 at 09:57:21AM CEST, john.fastab...@gmail.com wrote: >On 16-06-30 12:41 AM, Jiri Pirko wrote: >> Thu, Jun 30, 2016 at 09:13:55AM CEST, sridhar.samudr...@intel.com wrote: >>> >>> >>> On 6/29/2016 11:25 PM, Jiri Pirko wrote: Thu, Jun 30, 2016 at 06:04:39AM CEST, john.fastab...@g

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread John Fastabend
On 16-06-30 12:41 AM, Jiri Pirko wrote: > Thu, Jun 30, 2016 at 09:13:55AM CEST, sridhar.samudr...@intel.com wrote: >> >> >> On 6/29/2016 11:25 PM, Jiri Pirko wrote: >>> Thu, Jun 30, 2016 at 06:04:39AM CEST, john.fastab...@gmail.com wrote: On 16-06-29 08:35 PM, John Fastabend wrote: > On 16

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread Jiri Pirko
Thu, Jun 30, 2016 at 09:13:55AM CEST, sridhar.samudr...@intel.com wrote: > > >On 6/29/2016 11:25 PM, Jiri Pirko wrote: >>Thu, Jun 30, 2016 at 06:04:39AM CEST, john.fastab...@gmail.com wrote: >>>On 16-06-29 08:35 PM, John Fastabend wrote: On 16-06-29 03:09 PM, John Fastabend wrote: >On 16-06

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-30 Thread Samudrala, Sridhar
On 6/29/2016 11:25 PM, Jiri Pirko wrote: Thu, Jun 30, 2016 at 06:04:39AM CEST, john.fastab...@gmail.com wrote: On 16-06-29 08:35 PM, John Fastabend wrote: On 16-06-29 03:09 PM, John Fastabend wrote: On 16-06-29 02:33 PM, Or Gerlitz wrote: On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend wro

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread Jiri Pirko
Thu, Jun 30, 2016 at 06:04:39AM CEST, john.fastab...@gmail.com wrote: >On 16-06-29 08:35 PM, John Fastabend wrote: >> On 16-06-29 03:09 PM, John Fastabend wrote: >>> On 16-06-29 02:33 PM, Or Gerlitz wrote: On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend wrote: > On 16-06-29 07:48 AM,

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread John Fastabend
On 16-06-29 08:35 PM, John Fastabend wrote: > On 16-06-29 03:09 PM, John Fastabend wrote: >> On 16-06-29 02:33 PM, Or Gerlitz wrote: >>> On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend >>> wrote: On 16-06-29 07:48 AM, Or Gerlitz wrote: > On 6/28/2016 10:31 PM, John Fastabend wrote: >>

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread John Fastabend
On 16-06-29 03:09 PM, John Fastabend wrote: > On 16-06-29 02:33 PM, Or Gerlitz wrote: >> On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend >> wrote: >>> On 16-06-29 07:48 AM, Or Gerlitz wrote: On 6/28/2016 10:31 PM, John Fastabend wrote: > On 16-06-28 12:12 PM, Jiri Pirko wrote: >> >> W

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread John Fastabend
On 16-06-29 02:33 PM, Or Gerlitz wrote: > On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend > wrote: >> On 16-06-29 07:48 AM, Or Gerlitz wrote: >>> On 6/28/2016 10:31 PM, John Fastabend wrote: On 16-06-28 12:12 PM, Jiri Pirko wrote: > > Why?! Please, leave legacy be legacy. Use the new mod

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread Or Gerlitz
On Wed, Jun 29, 2016 at 7:35 PM, John Fastabend wrote: > On 16-06-29 07:48 AM, Or Gerlitz wrote: >> On 6/28/2016 10:31 PM, John Fastabend wrote: >>> On 16-06-28 12:12 PM, Jiri Pirko wrote: Why?! Please, leave legacy be legacy. Use the new mode for implementing new features. Don't make t

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread John Fastabend
On 16-06-29 07:48 AM, Or Gerlitz wrote: > On 6/28/2016 10:31 PM, John Fastabend wrote: >> On 16-06-28 12:12 PM, Jiri Pirko wrote: >>> >>> Why?! Please, leave legacy be legacy. Use the new mode for >>> implementing new features. Don't make things any more complicated :( >>> >> OK so how I read this

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread Or Gerlitz
On 6/28/2016 10:31 PM, John Fastabend wrote: On 16-06-28 12:12 PM, Jiri Pirko wrote: Why?! Please, leave legacy be legacy. Use the new mode for implementing new features. Don't make things any more complicated :( OK so how I read this is there are two things going on that are being conflated

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-29 Thread Or Gerlitz
On 6/28/2016 7:19 PM, John Fastabend wrote: On 16-06-28 03:25 AM, Or Gerlitz wrote: On 6/28/2016 8:57 AM, John Fastabend wrote: hmm so in the hardware I have there is actually a l2 table and various other tables so I don't have any issue with doing table setup. I would like to see a table_crea

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread John Fastabend
On 16-06-28 12:12 PM, Jiri Pirko wrote: > Tue, Jun 28, 2016 at 09:04:00PM CEST, sridhar.samudr...@intel.com wrote: >> >> >> On 6/28/2016 11:46 AM, Jiri Pirko wrote: >>> Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: On 16-06-28 09:19 AM, John Fastabend wrote: > On 16

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Jiri Pirko
Tue, Jun 28, 2016 at 09:04:00PM CEST, sridhar.samudr...@intel.com wrote: > > >On 6/28/2016 11:46 AM, Jiri Pirko wrote: >>Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: >>>On 16-06-28 09:19 AM, John Fastabend wrote: On 16-06-28 03:25 AM, Or Gerlitz wrote: >On 6/28/2016

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Samudrala, Sridhar
On 6/28/2016 11:46 AM, Jiri Pirko wrote: Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: On 16-06-28 09:19 AM, John Fastabend wrote: On 16-06-28 03:25 AM, Or Gerlitz wrote: On 6/28/2016 8:57 AM, John Fastabend wrote: On 16-06-27 09:07 AM, Saeed Mahameed wrote: Add the

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Jiri Pirko
Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: >On 16-06-28 09:19 AM, John Fastabend wrote: >> On 16-06-28 03:25 AM, Or Gerlitz wrote: >>> On 6/28/2016 8:57 AM, John Fastabend wrote: On 16-06-27 09:07 AM, Saeed Mahameed wrote: > Add the commands to set and show the m

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread John Fastabend
On 16-06-28 09:19 AM, John Fastabend wrote: > On 16-06-28 03:25 AM, Or Gerlitz wrote: >> On 6/28/2016 8:57 AM, John Fastabend wrote: >>> On 16-06-27 09:07 AM, Saeed Mahameed wrote: Add the commands to set and show the mode of SRIOV E-Switch, two modes are supported: * legacy :

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread John Fastabend
On 16-06-28 03:25 AM, Or Gerlitz wrote: > On 6/28/2016 8:57 AM, John Fastabend wrote: >> On 16-06-27 09:07 AM, Saeed Mahameed wrote: >>> Add the commands to set and show the mode of SRIOV E-Switch, two >>> modes are supported: >>> >>> * legacy : operating in the "old" L2 based mode (DMAC --> VF v

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Jiri Pirko
Mon, Jun 27, 2016 at 06:07:21PM CEST, sae...@mellanox.com wrote: >From: Or Gerlitz > >Add the commands to set and show the mode of SRIOV E-Switch, >two modes are supported: > >* legacy : operating in the "old" L2 based mode (DMAC --> VF vport) >* offloads : offloading SW rules/policy (e.g Bridge

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Or Gerlitz
On 6/28/2016 8:57 AM, John Fastabend wrote: On 16-06-27 09:07 AM, Saeed Mahameed wrote: Add the commands to set and show the mode of SRIOV E-Switch, two modes are supported: * legacy : operating in the "old" L2 based mode (DMAC --> VF vport) * offloads : offloading SW rules/policy (e.g Bridg

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-27 Thread John Fastabend
On 16-06-27 09:07 AM, Saeed Mahameed wrote: > From: Or Gerlitz > > Add the commands to set and show the mode of SRIOV E-Switch, > two modes are supported: > > * legacy : operating in the "old" L2 based mode (DMAC --> VF vport) > * offloads : offloading SW rules/policy (e.g Bridge/FDB or TC/Flo