Re: [PATCH net-next] bpf: netdev is never null in __dev_map_flush

2017-08-24 Thread Daniel Borkmann
On 08/24/2017 05:10 AM, John Fastabend wrote: On 08/23/2017 06:25 PM, Alexei Starovoitov wrote: On 8/23/17 6:20 PM, Daniel Borkmann wrote: No need to test for it in fast-path, every dev in bpf_dtab_netdev is guaranteed to be non-NULL, otherwise dev_map_update_elem() will fail in the first place

Re: [PATCH net-next] bpf: netdev is never null in __dev_map_flush

2017-08-23 Thread David Miller
From: Daniel Borkmann Date: Thu, 24 Aug 2017 03:20:11 +0200 > No need to test for it in fast-path, every dev in bpf_dtab_netdev > is guaranteed to be non-NULL, otherwise dev_map_update_elem() will > fail in the first place. > > Signed-off-by: Daniel Borkmann Applied.

Re: [PATCH net-next] bpf: netdev is never null in __dev_map_flush

2017-08-23 Thread John Fastabend
On 08/23/2017 06:25 PM, Alexei Starovoitov wrote: > On 8/23/17 6:20 PM, Daniel Borkmann wrote: >> No need to test for it in fast-path, every dev in bpf_dtab_netdev >> is guaranteed to be non-NULL, otherwise dev_map_update_elem() will >> fail in the first place. >> >> Signed-off-by: Daniel Borkmann

Re: [PATCH net-next] bpf: netdev is never null in __dev_map_flush

2017-08-23 Thread Alexei Starovoitov
On 8/23/17 6:20 PM, Daniel Borkmann wrote: No need to test for it in fast-path, every dev in bpf_dtab_netdev is guaranteed to be non-NULL, otherwise dev_map_update_elem() will fail in the first place. Signed-off-by: Daniel Borkmann wow. interesting. I'm surprised you see a difference from suc