On 08/24/2017 05:10 AM, John Fastabend wrote:
On 08/23/2017 06:25 PM, Alexei Starovoitov wrote:
On 8/23/17 6:20 PM, Daniel Borkmann wrote:
No need to test for it in fast-path, every dev in bpf_dtab_netdev
is guaranteed to be non-NULL, otherwise dev_map_update_elem() will
fail in the first place.
Signed-off-by: Daniel Borkmann <dan...@iogearbox.net>
wow. interesting. I'm surprised you see a difference from
such micro-optimization.
Acked-by: Alexei Starovoitov <a...@kernel.org>
Thanks for the clean up, I was a bit over paranoid here as well. Is
this actually noticeable in pps benchmark or just making the code
cleaner? Just curious.
No, just from going over the code wondering why it could be
null here but not elsewhere.
