Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-18 Thread Xin Long
On Tue, Aug 18, 2020 at 6:20 AM Cong Wang wrote: > > On Mon, Aug 17, 2020 at 2:39 PM David Miller wrote: > > > > From: Cong Wang > > Date: Mon, 17 Aug 2020 13:59:46 -0700 > > > > > Is this a new Kconfig feature? ipv6_stub was introduced for > > > VXLAN, at that time I don't remember we have such

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Cong Wang
On Mon, Aug 17, 2020 at 2:39 PM David Miller wrote: > > From: Cong Wang > Date: Mon, 17 Aug 2020 13:59:46 -0700 > > > Is this a new Kconfig feature? ipv6_stub was introduced for > > VXLAN, at that time I don't remember we have such kind of > > Kconfig rules, otherwise it would not be needed. > >

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread David Miller
From: Cong Wang Date: Mon, 17 Aug 2020 13:59:46 -0700 > Is this a new Kconfig feature? ipv6_stub was introduced for > VXLAN, at that time I don't remember we have such kind of > Kconfig rules, otherwise it would not be needed. The ipv6_stub exists in order to allow the troublesome "ipv6=m && fea

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread David Miller
From: Cong Wang Date: Mon, 17 Aug 2020 13:29:40 -0700 > On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote: >> >> TIPC=m and IPV6=m builds just fine. >> >> Having tipc autoload ipv6 is a different problem. (IMO) >> >> >> This Kconfig entry: >> menuconfig TIPC >> tristate "The TIPC Prot

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread David Miller
From: Cong Wang Date: Mon, 17 Aug 2020 11:55:55 -0700 > On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote: >> >> It just restricts how TIPC can be built, so that >> TIPC=y and IPV6=m cannot happen together, which causes >> a build error. > > It also disallows TIPC=m and IPV6=m, right? That c

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Cong Wang
On Mon, Aug 17, 2020 at 1:43 PM Randy Dunlap wrote: > > On 8/17/20 1:29 PM, Cong Wang wrote: > > On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote: > >> > >> TIPC=m and IPV6=m builds just fine. > >> > >> Having tipc autoload ipv6 is a different problem. (IMO) > >> > >> > >> This Kconfig entry:

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Randy Dunlap
On 8/17/20 1:29 PM, Cong Wang wrote: > On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote: >> >> TIPC=m and IPV6=m builds just fine. >> >> Having tipc autoload ipv6 is a different problem. (IMO) >> >> >> This Kconfig entry: >> menuconfig TIPC >> tristate "The TIPC Protocol" >> de

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Cong Wang
On Mon, Aug 17, 2020 at 12:55 PM Randy Dunlap wrote: > > TIPC=m and IPV6=m builds just fine. > > Having tipc autoload ipv6 is a different problem. (IMO) > > > This Kconfig entry: > menuconfig TIPC > tristate "The TIPC Protocol" > depends on INET > + depends on IPV6 || IPV6=n

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Randy Dunlap
On 8/17/20 12:26 PM, Cong Wang wrote: > On Mon, Aug 17, 2020 at 12:00 PM Randy Dunlap wrote: >> >> On 8/17/20 11:55 AM, Cong Wang wrote: >>> On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote: On 8/17/20 11:31 AM, Cong Wang wrote: > On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote:

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Cong Wang
On Mon, Aug 17, 2020 at 12:00 PM Randy Dunlap wrote: > > On 8/17/20 11:55 AM, Cong Wang wrote: > > On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote: > >> > >> On 8/17/20 11:31 AM, Cong Wang wrote: > >>> On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote: > > On Mon, Aug 17, 2020 at 2:2

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Randy Dunlap
On 8/17/20 11:55 AM, Cong Wang wrote: > On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote: >> >> On 8/17/20 11:31 AM, Cong Wang wrote: >>> On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote: On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote: > > Or put it into struct ipv6_stub? >>

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Cong Wang
On Mon, Aug 17, 2020 at 11:49 AM Randy Dunlap wrote: > > On 8/17/20 11:31 AM, Cong Wang wrote: > > On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote: > >> > >> On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote: > >>> > >>> Or put it into struct ipv6_stub? > >> Hi Cong, > >> > >> That could be one wa

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Randy Dunlap
On 8/17/20 11:31 AM, Cong Wang wrote: > On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote: >> >> On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote: >>> >>> Or put it into struct ipv6_stub? >> Hi Cong, >> >> That could be one way. We may do it when this new function becomes more >> common. >> By now,

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-17 Thread Cong Wang
On Sun, Aug 16, 2020 at 11:37 PM Xin Long wrote: > > On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote: > > > > Or put it into struct ipv6_stub? > Hi Cong, > > That could be one way. We may do it when this new function becomes more > common. > By now, I think it's okay to make TIPC depend on IPV6

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-16 Thread Xin Long
On Mon, Aug 17, 2020 at 2:29 AM Cong Wang wrote: > > On Sun, Aug 16, 2020 at 4:54 AM Xin Long wrote: > > > > When using ipv6_dev_find() in one module, it requires ipv6 not to > > work as a module. Otherwise, this error occurs in build: > > > > undefined reference to `ipv6_dev_find'. > > > > So

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-16 Thread David Miller
From: Xin Long Date: Sun, 16 Aug 2020 17:32:03 +0800 > When using ipv6_dev_find() in one module, it requires ipv6 not to > work as a module. Otherwise, this error occurs in build: > > undefined reference to `ipv6_dev_find'. > > So fix it by adding "depends on IPV6 || IPV6=n" to tipc/Kconfig,

Re: [PATCH net] tipc: not enable tipc when ipv6 works as a module

2020-08-16 Thread Cong Wang
On Sun, Aug 16, 2020 at 4:54 AM Xin Long wrote: > > When using ipv6_dev_find() in one module, it requires ipv6 not to > work as a module. Otherwise, this error occurs in build: > > undefined reference to `ipv6_dev_find'. > > So fix it by adding "depends on IPV6 || IPV6=n" to tipc/Kconfig, > as i