Re: [PATCH net] mcs7780: Silence uninitialized variable warning

2017-08-01 Thread Dan Carpenter
On Mon, Jul 31, 2017 at 10:37:16AM -0700, David Miller wrote: > From: Dan Carpenter > Date: Mon, 31 Jul 2017 10:41:40 +0300 > > > On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote: > >> From: Dan Carpenter > >> Date: Fri, 28 Jul 2017 17:45:11 +0300 > >> > >> > -__u16 rval; >

Re: [PATCH net] mcs7780: Silence uninitialized variable warning

2017-07-31 Thread David Miller
From: Dan Carpenter Date: Mon, 31 Jul 2017 10:41:40 +0300 > On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote: >> From: Dan Carpenter >> Date: Fri, 28 Jul 2017 17:45:11 +0300 >> >> > - __u16 rval; >> > + __u16 rval = -1; >> >> Fixing a bogus warning by assigning a signed constant

Re: [PATCH net] mcs7780: Silence uninitialized variable warning

2017-07-31 Thread Dan Carpenter
On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote: > From: Dan Carpenter > Date: Fri, 28 Jul 2017 17:45:11 +0300 > > > - __u16 rval; > > + __u16 rval = -1; > > Fixing a bogus warning by assigning a signed constant to an > unsigned variable doesn't really make me all that happy. >

Re: [PATCH net] mcs7780: Silence uninitialized variable warning

2017-07-29 Thread David Miller
From: Dan Carpenter Date: Fri, 28 Jul 2017 17:45:11 +0300 > - __u16 rval; > + __u16 rval = -1; Fixing a bogus warning by assigning a signed constant to an unsigned variable doesn't really make me all that happy. I don't think I'll apply this, sorry.