From: Dan Carpenter <dan.carpen...@oracle.com>
Date: Mon, 31 Jul 2017 10:41:40 +0300

> On Sat, Jul 29, 2017 at 11:28:55PM -0700, David Miller wrote:
>> From: Dan Carpenter <dan.carpen...@oracle.com>
>> Date: Fri, 28 Jul 2017 17:45:11 +0300
>> 
>> > -  __u16 rval;
>> > +  __u16 rval = -1;
>> 
>> Fixing a bogus warning by assigning a signed constant to an
>> unsigned variable doesn't really make me all that happy.
>> 
>> I don't think I'll apply this, sorry.
> 
> There's no guarantee that small kmallocs will always succeed in future
> kernels so it's not *totally* bogus.

Perhaps the burdon of initializing the value belongs in
mcs_get_reg(), and you can set it properly to 0xffff
instead of -1.

Ok?

Reply via email to