Re: [PATCH net] ipv6: add rcu grace period before freeing fib6_node

2017-08-19 Thread Martin KaFai Lau
On Sat, Aug 19, 2017 at 09:51:52AM -0700, Wei Wang wrote: > Hi Martin, > > >> +/* Function to safely get fn->sernum for passed in rt > >> + * and store result in passed in cookie. > >> + * Return true if we can get cookie safely > >> + * Return false if not > >> + */ > >> +static inline bool rt6_ge

Re: [PATCH net] ipv6: add rcu grace period before freeing fib6_node

2017-08-19 Thread Wei Wang
Hi Martin, >> +/* Function to safely get fn->sernum for passed in rt >> + * and store result in passed in cookie. >> + * Return true if we can get cookie safely >> + * Return false if not >> + */ >> +static inline bool rt6_get_cookie_safe(const struct rt6_info *rt, >> +

Re: [PATCH net] ipv6: add rcu grace period before freeing fib6_node

2017-08-18 Thread Martin KaFai Lau
On Fri, Aug 18, 2017 at 05:36:55PM -0700, Wei Wang wrote: > From: Wei Wang > > We currently keep rt->rt6i_node pointing to the fib6_node for the route. > And some functions make use of this pointer to dereference the fib6_node > from rt structure, e.g. rt6_check(). However, as there is neither > r