On Mon, Jun 11, 2018 at 11:56:56AM -0700, Siwei Liu wrote:
> The current implementation may only work with new userspace, even so
> the eth0/eth0nsby naming is not consistenly persisted due to races in
> bus probing.
Which race do you mean exactly?
--
MST
On 6/11/2018 12:34 PM, Samudrala, Sridhar wrote:
On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote:
On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:
* Set permanent and current address of net_failover device
to match the primary.
We copy the dev_addr of standby dev to
On 6/11/2018 11:10 AM, Michael S. Tsirkin wrote:
On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:
* Set permanent and current address of net_failover device
to match the primary.
* Carrier should be marked off before registering device
the net_failover device
On Mon, Jun 11, 2018 at 8:22 AM, Stephen Hemminger
wrote:
> On Fri, 8 Jun 2018 17:42:21 -0700
> Siwei Liu wrote:
>
>> On Fri, Jun 8, 2018 at 5:02 PM, Stephen Hemminger
>> wrote:
>> > On Fri, 8 Jun 2018 16:44:12 -0700
>> > Siwei Liu wrote:
>> >
>> >> On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemmi
On Fri, Jun 8, 2018 at 6:29 PM, Jakub Kicinski wrote:
> On Fri, 8 Jun 2018 16:44:12 -0700, Siwei Liu wrote:
>> >> I have a somewhat different view regarding IFF_HIDDEN. The purpose of
>> >> that flag, as well as the 1-netdev model, is to have a means to
>> >> inherit the interface name from the VF
On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:
> * Set permanent and current address of net_failover device
> to match the primary.
>
> * Carrier should be marked off before registering device
> the net_failover device.
Sridhar, do we want to address this?
If yes,
On Wed, Jun 06, 2018 at 03:21:21PM -0700, Stephen Hemminger wrote:
> > >
> > > I think you need to get rid of triggering off of the name change.
> >
> > Worth considering down the road since it's a bit of a hack but it's one
> > we won't have trouble supporting, unlike the delayed uplink.
>
>
On Fri, 8 Jun 2018 17:42:21 -0700
Siwei Liu wrote:
> On Fri, Jun 8, 2018 at 5:02 PM, Stephen Hemminger
> wrote:
> > On Fri, 8 Jun 2018 16:44:12 -0700
> > Siwei Liu wrote:
> >
> >> On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemminger
> >> wrote:
> >> > On Fri, 8 Jun 2018 15:25:59 -0700
> >> >
On Fri, 8 Jun 2018 15:54:38 -0700
Siwei Liu wrote:
> On Wed, Jun 6, 2018 at 2:54 PM, Samudrala, Sridhar
> wrote:
> >
> >
> > On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
> >>
> >> On Wed, 6 Jun 2018 15:30:27 +0300
> >> "Michael S. Tsirkin" wrote:
> >>
> >>> On Wed, Jun 06, 2018 at 09:25:12
On Fri, Jun 08, 2018 at 05:02:35PM -0700, Stephen Hemminger wrote:
> On Fri, 8 Jun 2018 16:44:12 -0700
> Siwei Liu wrote:
>
> > On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemminger
> > wrote:
> > > On Fri, 8 Jun 2018 15:25:59 -0700
> > > Siwei Liu wrote:
> > >
> > >> On Wed, Jun 6, 2018 at 2:24
On Fri, 8 Jun 2018 16:44:12 -0700, Siwei Liu wrote:
> >> I have a somewhat different view regarding IFF_HIDDEN. The purpose of
> >> that flag, as well as the 1-netdev model, is to have a means to
> >> inherit the interface name from the VF, and to eliminate playing hacks
> >> around renaming device
On Fri, Jun 8, 2018 at 5:02 PM, Stephen Hemminger
wrote:
> On Fri, 8 Jun 2018 16:44:12 -0700
> Siwei Liu wrote:
>
>> On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemminger
>> wrote:
>> > On Fri, 8 Jun 2018 15:25:59 -0700
>> > Siwei Liu wrote:
>> >
>> >> On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemmin
On Fri, 8 Jun 2018 16:44:12 -0700
Siwei Liu wrote:
> On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemminger
> wrote:
> > On Fri, 8 Jun 2018 15:25:59 -0700
> > Siwei Liu wrote:
> >
> >> On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemminger
> >> wrote:
> >> > On Wed, 6 Jun 2018 15:30:27 +0300
> >> >
On Fri, Jun 8, 2018 at 4:18 PM, Stephen Hemminger
wrote:
> On Fri, 8 Jun 2018 15:25:59 -0700
> Siwei Liu wrote:
>
>> On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemminger
>> wrote:
>> > On Wed, 6 Jun 2018 15:30:27 +0300
>> > "Michael S. Tsirkin" wrote:
>> >
>> >> On Wed, Jun 06, 2018 at 09:25:12AM
On Fri, 8 Jun 2018 15:25:59 -0700
Siwei Liu wrote:
> On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemminger
> wrote:
> > On Wed, 6 Jun 2018 15:30:27 +0300
> > "Michael S. Tsirkin" wrote:
> >
> >> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> >> > Tue, Jun 05, 2018 at 05:42:31AM C
On Wed, Jun 6, 2018 at 2:54 PM, Samudrala, Sridhar
wrote:
>
>
> On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
>>
>> On Wed, 6 Jun 2018 15:30:27 +0300
>> "Michael S. Tsirkin" wrote:
>>
>>> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
Tue, Jun 05, 2018 at 05:42:31AM CEST, s
On Wed, Jun 6, 2018 at 2:24 PM, Stephen Hemminger
wrote:
> On Wed, 6 Jun 2018 15:30:27 +0300
> "Michael S. Tsirkin" wrote:
>
>> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
>> > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
>> > >The net failover should be
On Fri, Jun 08, 2018 at 11:30:08AM -0700, Stephen Hemminger wrote:
> * what about nested KVM on Hyper-V? Would it make sense to
> have a way to pass subset of VF queues to guest?
No as long as hyper-v doesn't have a vIOMMU.
--
MST
On Thu, 7 Jun 2018 20:22:15 +0300
"Michael S. Tsirkin" wrote:
> On Thu, Jun 07, 2018 at 09:17:42AM -0700, Stephen Hemminger wrote:
> > On Thu, 7 Jun 2018 18:41:31 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > > > Why would DPDK care what we do in the kernel? Isn't it just slapping
> > > > >
On Thu, Jun 07, 2018 at 09:17:42AM -0700, Stephen Hemminger wrote:
> On Thu, 7 Jun 2018 18:41:31 +0300
> "Michael S. Tsirkin" wrote:
>
> > > > Why would DPDK care what we do in the kernel? Isn't it just slapping
> > > > vfio-pci on the netdevs it sees?
> > >
> > > Alex, you are correct for Int
On Thu, 7 Jun 2018 18:41:31 +0300
"Michael S. Tsirkin" wrote:
> > > Why would DPDK care what we do in the kernel? Isn't it just slapping
> > > vfio-pci on the netdevs it sees?
> >
> > Alex, you are correct for Intel devices; but DPDK on Azure is not Intel
> > based.,.
> > The DPDK support use
On Thu, Jun 07, 2018 at 07:51:12AM -0700, Stephen Hemminger wrote:
> On Thu, 7 Jun 2018 07:17:51 -0700
> Alexander Duyck wrote:
>
> > On Wed, Jun 6, 2018 at 3:25 PM, Stephen Hemminger
> > wrote:
> > > On Wed, 6 Jun 2018 14:54:04 -0700
> > > "Samudrala, Sridhar" wrote:
> > >
> > >> On 6/6/2018
On Thu, 7 Jun 2018 17:57:50 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 06, 2018 at 03:24:08PM -0700, Stephen Hemminger wrote:
> > On Thu, 7 Jun 2018 00:47:52 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote:
> > > > On We
On Wed, Jun 06, 2018 at 03:24:08PM -0700, Stephen Hemminger wrote:
> On Thu, 7 Jun 2018 00:47:52 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote:
> > > On Wed, 6 Jun 2018 15:30:27 +0300
> > > "Michael S. Tsirkin" wrote:
> > >
> > > >
On Thu, 7 Jun 2018 07:17:51 -0700
Alexander Duyck wrote:
> On Wed, Jun 6, 2018 at 3:25 PM, Stephen Hemminger
> wrote:
> > On Wed, 6 Jun 2018 14:54:04 -0700
> > "Samudrala, Sridhar" wrote:
> >
> >> On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
> >> > On Wed, 6 Jun 2018 15:30:27 +0300
> >> >
On Wed, Jun 6, 2018 at 3:25 PM, Stephen Hemminger
wrote:
> On Wed, 6 Jun 2018 14:54:04 -0700
> "Samudrala, Sridhar" wrote:
>
>> On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
>> > On Wed, 6 Jun 2018 15:30:27 +0300
>> > "Michael S. Tsirkin" wrote:
>> >
>> >> On Wed, Jun 06, 2018 at 09:25:12AM +020
On Wed, 6 Jun 2018 15:19:30 +0300
"Michael S. Tsirkin" wrote:
> On Tue, Jun 05, 2018 at 08:51:18PM -0700, Stephen Hemminger wrote:
> > > I think the push back was with the usage of the delay, not bringing up
> > > the primary/standby
> > > device in the name change event handler.
> > > Can't net
On Wed, 6 Jun 2018 14:54:04 -0700
"Samudrala, Sridhar" wrote:
> On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
> > On Wed, 6 Jun 2018 15:30:27 +0300
> > "Michael S. Tsirkin" wrote:
> >
> >> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> >>> Tue, Jun 05, 2018 at 05:42:31AM CEST,
On Thu, 7 Jun 2018 00:47:52 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote:
> > On Wed, 6 Jun 2018 15:30:27 +0300
> > "Michael S. Tsirkin" wrote:
> >
> > > On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> > > > Tue, Jun 05,
On Thu, 7 Jun 2018 00:30:21 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 06, 2018 at 02:16:20PM -0700, Stephen Hemminger wrote:
> > On Tue, 5 Jun 2018 23:11:37 -0700
> > "Samudrala, Sridhar" wrote:
> >
> > > On 6/5/2018 11:00 PM, Stephen Hemminger wrote:
> > > > On Tue, 5 Jun 2018 22:39:
On 6/6/2018 2:24 PM, Stephen Hemminger wrote:
On Wed, 6 Jun 2018 15:30:27 +0300
"Michael S. Tsirkin" wrote:
On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
The net failover should be a simple library, not
On Wed, Jun 06, 2018 at 02:24:47PM -0700, Stephen Hemminger wrote:
> On Wed, 6 Jun 2018 15:30:27 +0300
> "Michael S. Tsirkin" wrote:
>
> > On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> > > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> > > >The net fai
On Wed, Jun 06, 2018 at 02:16:20PM -0700, Stephen Hemminger wrote:
> On Tue, 5 Jun 2018 23:11:37 -0700
> "Samudrala, Sridhar" wrote:
>
> > On 6/5/2018 11:00 PM, Stephen Hemminger wrote:
> > > On Tue, 5 Jun 2018 22:39:12 -0700
> > > "Samudrala, Sridhar" wrote:
> > >
> > >> On 6/5/2018 8:51 PM,
On Wed, 6 Jun 2018 09:25:12 +0200
Jiri Pirko wrote:
> Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> >The net failover should be a simple library, not a virtual
> >object with function callbacks (see callback hell).
>
> Why just a library? It should do a common thing
On Wed, 6 Jun 2018 15:30:27 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> > Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> > >The net failover should be a simple library, not a virtual
> > >object with function callb
On Tue, 5 Jun 2018 23:11:37 -0700
"Samudrala, Sridhar" wrote:
> On 6/5/2018 11:00 PM, Stephen Hemminger wrote:
> > On Tue, 5 Jun 2018 22:39:12 -0700
> > "Samudrala, Sridhar" wrote:
> >
> >> On 6/5/2018 8:51 PM, Stephen Hemminger wrote:
> >>> On Tue, 5 Jun 2018 16:52:22 -0700
> >>> "Samudrala
On Wed, Jun 06, 2018 at 09:25:12AM +0200, Jiri Pirko wrote:
> Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
> >The net failover should be a simple library, not a virtual
> >object with function callbacks (see callback hell).
>
> Why just a library? It should do a common t
On Tue, Jun 05, 2018 at 08:51:18PM -0700, Stephen Hemminger wrote:
> > I think the push back was with the usage of the delay, not bringing up the
> > primary/standby
> > device in the name change event handler.
> > Can't netvsc use this mechanism instead of depending on the delay?
> >
> >
>
> T
Tue, Jun 05, 2018 at 05:42:31AM CEST, step...@networkplumber.org wrote:
>The net failover should be a simple library, not a virtual
>object with function callbacks (see callback hell).
Why just a library? It should do a common things. I think it should be a
virtual object. Looks like your patch ag
On 6/5/2018 11:00 PM, Stephen Hemminger wrote:
On Tue, 5 Jun 2018 22:39:12 -0700
"Samudrala, Sridhar" wrote:
On 6/5/2018 8:51 PM, Stephen Hemminger wrote:
On Tue, 5 Jun 2018 16:52:22 -0700
"Samudrala, Sridhar" wrote:
On 6/5/2018 2:52 PM, Stephen Hemminger wrote:
On Tue, 5 Jun 2018 22
On Tue, 5 Jun 2018 22:39:12 -0700
"Samudrala, Sridhar" wrote:
> On 6/5/2018 8:51 PM, Stephen Hemminger wrote:
> > On Tue, 5 Jun 2018 16:52:22 -0700
> > "Samudrala, Sridhar" wrote:
> >
> >> On 6/5/2018 2:52 PM, Stephen Hemminger wrote:
> >>> On Tue, 5 Jun 2018 22:38:43 +0300
> >>> "Michael S.
On 6/5/2018 8:51 PM, Stephen Hemminger wrote:
On Tue, 5 Jun 2018 16:52:22 -0700
"Samudrala, Sridhar" wrote:
On 6/5/2018 2:52 PM, Stephen Hemminger wrote:
On Tue, 5 Jun 2018 22:38:43 +0300
"Michael S. Tsirkin" wrote:
See:
https://patchwork.ozlabs.org/patch/851711/
Let me try to summ
On Tue, 5 Jun 2018 16:52:22 -0700
"Samudrala, Sridhar" wrote:
> On 6/5/2018 2:52 PM, Stephen Hemminger wrote:
> > On Tue, 5 Jun 2018 22:38:43 +0300
> > "Michael S. Tsirkin" wrote:
> >
> >>> See:
> >>> https://patchwork.ozlabs.org/patch/851711/
> >> Let me try to summarize that:
> >>
> >>
On 6/5/2018 2:52 PM, Stephen Hemminger wrote:
On Tue, 5 Jun 2018 22:38:43 +0300
"Michael S. Tsirkin" wrote:
See:
https://patchwork.ozlabs.org/patch/851711/
Let me try to summarize that:
You wanted to speed up the delayed link up. You had an idea to
additionally take link
On Tue, 5 Jun 2018 22:38:43 +0300
"Michael S. Tsirkin" wrote:
> >
> > See:
> >https://patchwork.ozlabs.org/patch/851711/
>
> Let me try to summarize that:
>
> You wanted to speed up the delayed link up. You had an idea to
> additionally take link up when userspace renames th
On Tue, Jun 05, 2018 at 11:53:05AM -0700, Stephen Hemminger wrote:
> > > * Now, netvsc and net_failover use the same delayed work type
> > > mechanism for setup. Previously, net_failover code was triggering off
> > > name change but a similar policy was rejected for netvsc.
> > > "wha
On Tue, 5 Jun 2018 21:35:26 +0300
"Michael S. Tsirkin" wrote:
> Thanks, I think this is nice patch but I wonder whether it can be split
> up somewhat. Not all of it is uncontroversial.
I started that way, but then I was fixing code that was later deleted.
The big change was eliminating the callb
Thanks, I think this is nice patch but I wonder whether it can be split
up somewhat. Not all of it is uncontroversial.
On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote:
> * The matching of secondary device to primary device policy
> is up to the network device. Both net_fail
From: Stephen Hemminger
Date: Tue, 5 Jun 2018 10:45:10 -0700
> I said it wasn't tested. Not surprising. Don't have a version of KVM
> that supports standby (and not going to build KVM from scratch for
> this).
It would definitely help me if you put "RFC" in the subject line
for patches which are
On Tue, 5 Jun 2018 10:22:13 -0700
"Samudrala, Sridhar" wrote:
> On 6/4/2018 8:42 PM, Stephen Hemminger wrote:
> > The net failover should be a simple library, not a virtual
> > object with function callbacks (see callback hell).
> > The code is simpler is smaller both for the netvsc and virtio us
On 6/4/2018 8:42 PM, Stephen Hemminger wrote:
The net failover should be a simple library, not a virtual
object with function callbacks (see callback hell).
The code is simpler is smaller both for the netvsc and virtio use case.
I quickly tried this patch and it breaks virtio-net in standby mod
51 matches
Mail list logo
