Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-22 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Mon, Oct 21, 2019 at 12:01 PM Jakub Sitnicki wrote: >> >> On Mon, Oct 21, 2019 at 06:57 PM CEST, Andrii Nakryiko wrote: >> > LIBBPF_OPTS is implemented as a mix of field declaration and memset >> > + assignment. This makes it neither variable declaration nor purely >

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Andrii Nakryiko
On Mon, Oct 21, 2019 at 12:01 PM Jakub Sitnicki wrote: > > On Mon, Oct 21, 2019 at 06:57 PM CEST, Andrii Nakryiko wrote: > > LIBBPF_OPTS is implemented as a mix of field declaration and memset > > + assignment. This makes it neither variable declaration nor purely > > statements, which is a proble

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Jakub Sitnicki
On Mon, Oct 21, 2019 at 06:57 PM CEST, Andrii Nakryiko wrote: > LIBBPF_OPTS is implemented as a mix of field declaration and memset > + assignment. This makes it neither variable declaration nor purely > statements, which is a problem, because you can't mix it with either > other variable declarati

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Yonghong Song
On 10/21/19 10:38 AM, Andrii Nakryiko wrote: > On Mon, Oct 21, 2019 at 10:18 AM Toke Høiland-Jørgensen > wrote: >> >> Andrii Nakryiko writes: >> >>> LIBBPF_OPTS is implemented as a mix of field declaration and memset >>> + assignment. This makes it neither variable declaration nor purely >>> s

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Andrii Nakryiko
On Mon, Oct 21, 2019 at 10:18 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > LIBBPF_OPTS is implemented as a mix of field declaration and memset > > + assignment. This makes it neither variable declaration nor purely > > statements, which is a problem, because you can't mix it

Re: [PATCH bpf-next] libbpf: make LIBBPF_OPTS macro strictly a variable declaration

2019-10-21 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > LIBBPF_OPTS is implemented as a mix of field declaration and memset > + assignment. This makes it neither variable declaration nor purely > statements, which is a problem, because you can't mix it with either > other variable declarations nor other function statements, b