Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

2018-06-15 Thread Daniel Borkmann
On 06/15/2018 02:43 PM, William Tu wrote: > On Thu, Jun 14, 2018 at 10:24 PM, Eyal Birger wrote: >> >> >>> On 14 Jun 2018, at 15:01, William Tu wrote: >>> >>> Make the printting of bpf xfrm tunnel better and >>> cleanup xfrm state and policy when xfrm test finishes. >> >> Yeah the ‘tee’ was usefu

Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

2018-06-15 Thread William Tu
On Thu, Jun 14, 2018 at 10:24 PM, Eyal Birger wrote: > > >> On 14 Jun 2018, at 15:01, William Tu wrote: >> >> Make the printting of bpf xfrm tunnel better and >> cleanup xfrm state and policy when xfrm test finishes. > > Yeah the ‘tee’ was useful when developing the test - I could see what’s goin

Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

2018-06-14 Thread Eyal Birger
> On 14 Jun 2018, at 15:01, William Tu wrote: > > Make the printting of bpf xfrm tunnel better and > cleanup xfrm state and policy when xfrm test finishes. Yeah the ‘tee’ was useful when developing the test - I could see what’s going on :) Now that it’s in ‘selftests’ it’s definitely better

Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

2018-06-14 Thread Daniel Borkmann
On 06/15/2018 02:05 AM, Daniel Borkmann wrote: > On 06/15/2018 12:30 AM, Martin KaFai Lau wrote: >> On Thu, Jun 14, 2018 at 05:01:06AM -0700, William Tu wrote: >>> Make the printting of bpf xfrm tunnel better and >>> cleanup xfrm state and policy when xfrm test finishes. >> LGTM. The subject tag a

Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

2018-06-14 Thread Daniel Borkmann
On 06/15/2018 12:30 AM, Martin KaFai Lau wrote: > On Thu, Jun 14, 2018 at 05:01:06AM -0700, William Tu wrote: >> Make the printting of bpf xfrm tunnel better and >> cleanup xfrm state and policy when xfrm test finishes. > LGTM. The subject tag actually meant s/bpf-net/bpf-next/? > > It makes sens

Re: [PATCH bpf-net] selftests/bpf: delete xfrm tunnel when test exits.

2018-06-14 Thread Martin KaFai Lau
On Thu, Jun 14, 2018 at 05:01:06AM -0700, William Tu wrote: > Make the printting of bpf xfrm tunnel better and > cleanup xfrm state and policy when xfrm test finishes. LGTM. The subject tag actually meant s/bpf-net/bpf-next/? It makes sense to be in bpf-next but I think bpf-next is still closed.