Re: [PATCH 06/11] IB/cma: Refactor RDMA IP CM private-data parsing code

2015-06-16 Thread Haggai Eran
On 16/06/2015 01:33, Hefty, Sean wrote: >> -static int cma_save_net_info(struct rdma_cm_id *id, struct rdma_cm_id >> *listen_id, >> - struct ib_cm_event *ib_event) >> +static u16 cma_port_from_service_id(__be64 service_id) >> { >> -struct cma_hdr *hdr; >> +return be

RE: [PATCH 06/11] IB/cma: Refactor RDMA IP CM private-data parsing code

2015-06-15 Thread Hefty, Sean
> -static int cma_save_net_info(struct rdma_cm_id *id, struct rdma_cm_id > *listen_id, > - struct ib_cm_event *ib_event) > +static u16 cma_port_from_service_id(__be64 service_id) > { > - struct cma_hdr *hdr; > + return be64_to_cpu(service_id); > +} Nit - Does the