On 16/06/2015 01:33, Hefty, Sean wrote:
>> -static int cma_save_net_info(struct rdma_cm_id *id, struct rdma_cm_id
>> *listen_id,
>> - struct ib_cm_event *ib_event)
>> +static u16 cma_port_from_service_id(__be64 service_id)
>> {
>> - struct cma_hdr *hdr;
>> + return be64_to_cpu(service_id);
>> +}
>
> Nit - Does the compiler not complain about the cast from u64 to u16?
>
Apparently it does, but only with W=3 (-Wconversion is included there).
W=3 produces about 6k warnings when compiling cma.c, so I don't usually
enable it.
I'll add a cast there to prevent the warning.
Haggai
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
