Re: [PATCH] net: smc91x: propagate irq return code

2016-02-01 Thread Robert Jarzmik
Sergei Shtylyov writes: > On 02/01/2016 11:41 PM, Robert Jarzmik wrote: > The smc91x driver doesn't honor the probe deferral mechanism when the interrupt source is not yet available, such as one provided by a gpio controller not probed. > >>> What if 'ndev->irq' does equal 0? >

Re: [PATCH] net: smc91x: propagate irq return code

2016-02-01 Thread Sergei Shtylyov
On 02/01/2016 11:41 PM, Robert Jarzmik wrote: The smc91x driver doesn't honor the probe deferral mechanism when the interrupt source is not yet available, such as one provided by a gpio controller not probed. What if 'ndev->irq' does equal 0? That's not possible AFAIR. Possible if

Re: [PATCH] net: smc91x: propagate irq return code

2016-02-01 Thread Robert Jarzmik
Sergei Shtylyov writes: > Hello. > > On 2/1/2016 1:46 AM, Robert Jarzmik wrote: > >> The smc91x driver doesn't honor the probe deferral mechanism when the >> interrupt source is not yet available, such as one provided by a gpio >> controller not probed. >What if 'ndev->irq' does equal 0? That

Re: [PATCH] net: smc91x: propagate irq return code

2016-02-01 Thread Sergei Shtylyov
Hello. On 2/1/2016 1:46 AM, Robert Jarzmik wrote: The smc91x driver doesn't honor the probe deferral mechanism when the interrupt source is not yet available, such as one provided by a gpio controller not probed. Fix this by propagating the platform_get_irq() error code as the probe return val