Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes:
> On 02/01/2016 11:41 PM, Robert Jarzmik wrote:
>
>>>> The smc91x driver doesn't honor the probe deferral mechanism when the
>>>> interrupt source is not yet available, such as one provided by a gpio
>>>> controller not probed.
>
>>> What if 'ndev->irq' does equal 0?
>
>> That's not possible AFAIR.
>
> Possible if of_irq_get() returns 0 (and it will on failure!).
Ah good catch, didn't know that one.
>> And yet, that test now looks weird to me. I think I'll respin the patch with
>> a
>> "if (ndev->irq < 0) {" instead of the "if (ndev->irq <= 0) {".
>
> Defeating Linus' PoV as a result... ;-)
Well, I'd rather face the wrath of others if I'm convinced the code is more
correct. And in this case you convinced me :)
--
Robert
