Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-15 Thread David Miller
From: Ahmed Abdelsalam Date: Wed, 15 Nov 2017 12:42:02 +0100 > For the time being, Can i submit another patch updating the > "reserved" bits to be "tag" and just adding a comment next the > "first_segment". Yes.

Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-15 Thread Ahmed Abdelsalam
On Wed, 15 Nov 2017 09:55:32 +0900 (KST) David Miller wrote: > From: Ahmed Abdelsalam > Date: Tue, 14 Nov 2017 15:31:48 +0100 > > > Also it will not make sense to have the field name differnent from the > > draft. > > That is the danger of defining user facing things against a draft which > i

Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-14 Thread David Miller
From: Ahmed Abdelsalam Date: Tue, 14 Nov 2017 15:31:48 +0100 > Also it will not make sense to have the field name differnent from the draft. That is the danger of defining user facing things against a draft which is constantly changing. Sorry, we are stuck with the current name.

Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-14 Thread David Miller
From: Edward Cree Date: Tue, 14 Nov 2017 14:14:01 + > On 14/11/17 12:37, David Miller wrote: >> From: Ahmed Abdelsalam >> Date: Sun, 12 Nov 2017 21:37:01 +0100 >> >>> diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h >>> index 2f6fb0d..3f4b3ab 100644 >>> --- a/include/uapi/

Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-14 Thread Ahmed Abdelsalam
On Tue, 14 Nov 2017 14:14:01 + Edward Cree wrote: > On 14/11/17 12:37, David Miller wrote: > > From: Ahmed Abdelsalam > > Date: Sun, 12 Nov 2017 21:37:01 +0100 > > > >> diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h > >> index 2f6fb0d..3f4b3ab 100644 > >> --- a/include/u

Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-14 Thread Edward Cree
On 14/11/17 12:37, David Miller wrote: > From: Ahmed Abdelsalam > Date: Sun, 12 Nov 2017 21:37:01 +0100 > >> diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h >> index 2f6fb0d..3f4b3ab 100644 >> --- a/include/uapi/linux/seg6.h >> +++ b/include/uapi/linux/seg6.h >> @@ -26,9 +26,9

Re: [PATCH] ipv6: sr: update the struct ipv6_sr_hdr

2017-11-14 Thread David Miller
From: Ahmed Abdelsalam Date: Sun, 12 Nov 2017 21:37:01 +0100 > diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h > index 2f6fb0d..3f4b3ab 100644 > --- a/include/uapi/linux/seg6.h > +++ b/include/uapi/linux/seg6.h > @@ -26,9 +26,9 @@ struct ipv6_sr_hdr { > __u8hdrlen; >