Re: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-02-27 Thread Marc Kleine-Budde
On 1/31/19 10:37 AM, Joakim Zhang wrote: > Current we can meet timeout issue when setting a small bitrate like 1 > as follows on i.MX6UL EVK board (ipg clock = 66MHZ, per clock = 30MHZ): > root@imx6ul7d:~# ip link set can0 up type can bitrate 1 > A link change request failed with some chang

RE: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-02-14 Thread Joakim Zhang
Kindly Ping... Reviewed-by: Dong Aisheng Best Regards, Joakim Zhang > -Original Message- > From: Joakim Zhang > Sent: 2019年1月31日 17:37 > To: m...@pengutronix.de; linux-...@vger.kernel.org > Cc: w...@grandegger.com; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; dl-linux-imx ;

RE: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-01-31 Thread Aisheng Dong
> -Original Message- > From: Joakim Zhang > Sent: Thursday, January 31, 2019 5:37 PM > To: m...@pengutronix.de; linux-...@vger.kernel.org > Cc: w...@grandegger.com; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; dl-linux-imx ; Joakim > Zhang > Subject: [PATCH] can: flexcan: fix ti

RE: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-01-31 Thread Joakim Zhang
Hi Marc, > -Original Message- > From: Marc Kleine-Budde > Sent: 2019年1月31日 17:12 > To: Joakim Zhang ; linux-...@vger.kernel.org > Cc: w...@grandegger.com; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; dl-linux-imx ; Aisheng > Dong > Subject: Re: [

Re: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-01-31 Thread Marc Kleine-Budde
On 1/31/19 9:48 AM, Joakim Zhang wrote: >> Which SoC are you using? Which clock rate has the flexcan IP core? > > We tested on i.MX6 series boards and all met this issue. And ipg clock rate > is 66MHZ, per clock rate is 30MHZ. ok > >>> It is caused by calling of flexcan_chip_unfreeze() timeo

RE: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-01-31 Thread Aisheng Dong
> From: Joakim Zhang > Sent: Thursday, January 31, 2019 4:49 PM [...] > > > Current we can meet timeout issue when setting a small bitrate like > > > 1 as follows: > > > root@imx6qdlsolo:~# ip link set can0 up type can bitrate 1 A > > > link change request failed with some changes committed

RE: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-01-31 Thread Joakim Zhang
Hi Marc, > -Original Message- > From: Marc Kleine-Budde > Sent: 2019年1月31日 15:34 > To: Joakim Zhang ; linux-...@vger.kernel.org > Cc: w...@grandegger.com; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; dl-linux-imx ; Aisheng > Dong > Subject: Re: [

Re: [PATCH] can: flexcan: fix timeout when set small bitrate

2019-01-30 Thread Marc Kleine-Budde
On 1/31/19 7:58 AM, Joakim Zhang wrote: > From: Dong Aisheng > > Current we can meet timeout issue when setting a small bitrate > like 1 as follows: > root@imx6qdlsolo:~# ip link set can0 up type can bitrate 1 > A link change request failed with some changes committed already. > Interface