Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread Jiri Pirko
Mon, Oct 21, 2019 at 06:11:33PM CEST, dsah...@gmail.com wrote: >On 10/21/19 9:56 AM, Jiri Pirko wrote: >> >> I forgot to update the desc. Uppercase chars are now allowed as Andrew >> requested. Regarding dash, it could be allowed of course. But why isn't >> "_" enough. I mean, I think it would be

Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread David Ahern
On 10/21/19 9:56 AM, Jiri Pirko wrote: > > I forgot to update the desc. Uppercase chars are now allowed as Andrew > requested. Regarding dash, it could be allowed of course. But why isn't > "_" enough. I mean, I think it would be good to maintain allowed chars > within a limit. That's a personal

Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread Jiri Pirko
Mon, Oct 21, 2019 at 05:20:07PM CEST, dsah...@gmail.com wrote: >On 10/21/19 8:26 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently, the name format is not required by the code, however it is >> required during patch review. All params added until now are in-lined >> with the following for

Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread Andrew Lunn
On Mon, Oct 21, 2019 at 09:20:07AM -0600, David Ahern wrote: > On 10/21/19 8:26 AM, Jiri Pirko wrote: > > From: Jiri Pirko > > > > Currently, the name format is not required by the code, however it is > > required during patch review. All params added until now are in-lined > > with the following

Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread David Ahern
On 10/21/19 8:26 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Currently, the name format is not required by the code, however it is > required during patch review. All params added until now are in-lined > with the following format: > 1) lowercase characters, digits and underscored are allowed >

[patch net-next v3 3/3] devlink: add format requirement for devlink object names

2019-10-21 Thread Jiri Pirko
From: Jiri Pirko Currently, the name format is not required by the code, however it is required during patch review. All params added until now are in-lined with the following format: 1) lowercase characters, digits and underscored are allowed 2) underscore is neither at the beginning nor at the