Re: [patch 3/3] Add netpoll/netconsole support to vlan devices

2006-09-26 Thread Jesper Juhl
On 26/09/06, David Miller <[EMAIL PROTECTED]> wrote: From: [EMAIL PROTECTED] Date: Mon, 25 Sep 2006 16:43:10 -0700 > +#ifdef CONFIG_NET_POLL_CONTROLLER > + new_dev->poll_controller = real_dev->poll_controller; > +#endif > + I don't see how this part can be correct. If netpoll actually call

Re: [patch 3/3] Add netpoll/netconsole support to vlan devices

2006-09-25 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 25 Sep 2006 16:43:10 -0700 > +#ifdef CONFIG_NET_POLL_CONTROLLER > + new_dev->poll_controller = real_dev->poll_controller; > +#endif > + I don't see how this part can be correct. If netpoll actually calls new_dev->poll_controller it will pass new_dev in (ie.

[patch 3/3] Add netpoll/netconsole support to vlan devices

2006-09-25 Thread akpm
From: Jesper Juhl <[EMAIL PROTECTED]> I recently tried running netconsole via a vlan interface without luck, and decided to do something about it (see patch below). My interfaces look like this: eth0 Link encap:Ethernet HWaddr 00:14:5E:28:3C:2E UP BROADCAST RUNNING MULTICAST MTU