From: [EMAIL PROTECTED]
Date: Mon, 25 Sep 2006 16:43:10 -0700

> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +     new_dev->poll_controller = real_dev->poll_controller;
> +#endif
> +

I don't see how this part can be correct.  If netpoll actually
calls new_dev->poll_controller it will pass new_dev in
(ie. the VLAN device) yet this method is for real_dev.

If the only side effect of this assignment is that netpoll recognizes
the device as being usable with netpoll, that's really a nasty way to
accomplish that.

In any event, propagating this method pointer to the wrong device
structure is a bug.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to