XDP_DROP and XDP_TX (Was: Re: [net-next PATCH v5 0/6] XDP for virtio_net)

2016-12-13 Thread Jesper Dangaard Brouer
On Thu, 8 Dec 2016 11:38:16 -0800 Alexei Starovoitov wrote: > On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: > > From: John Fastabend > > Date: Wed, 07 Dec 2016 12:10:47 -0800 > > [...] > > > Can't we disable XDP_TX somehow? Many people might only want RX drop, > > > and extra

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread Michael S. Tsirkin
On Thu, Dec 08, 2016 at 05:16:02PM -0500, David Miller wrote: > From: John Fastabend > Date: Thu, 8 Dec 2016 12:46:07 -0800 > > > On 16-12-08 11:38 AM, Alexei Starovoitov wrote: > >> On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: > >>> From: John Fastabend > >>> Date: Wed, 07 Dec

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread David Miller
From: John Fastabend Date: Thu, 8 Dec 2016 12:46:07 -0800 > On 16-12-08 11:38 AM, Alexei Starovoitov wrote: >> On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: >>> From: John Fastabend >>> Date: Wed, 07 Dec 2016 12:10:47 -0800 >>> This implements virtio_net for the mergeable bu

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread Michael S. Tsirkin
On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: > From: John Fastabend > Date: Wed, 07 Dec 2016 12:10:47 -0800 > > > This implements virtio_net for the mergeable buffers and big_packet > > modes. I tested this with vhost_net running on qemu and did not see > > any issues. For testin

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread Michael S. Tsirkin
On Thu, Dec 08, 2016 at 10:58:52PM +0200, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 12:46:07PM -0800, John Fastabend wrote: > > On 16-12-08 11:38 AM, Alexei Starovoitov wrote: > > > On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: > > >> From: John Fastabend > > >> Date: Wed

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread Alexei Starovoitov
On Thu, Dec 08, 2016 at 12:46:07PM -0800, John Fastabend wrote: > > Fair enough but disabling LRO to handle the case where you "might" get > a DDOS will hurt normal good traffic. the xdp_pass path is not optimized right now. so even without VMs we need some work to do. lro or not-lro is imo secon

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread Michael S. Tsirkin
On Thu, Dec 08, 2016 at 12:46:07PM -0800, John Fastabend wrote: > On 16-12-08 11:38 AM, Alexei Starovoitov wrote: > > On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: > >> From: John Fastabend > >> Date: Wed, 07 Dec 2016 12:10:47 -0800 > >> > >>> This implements virtio_net for the mer

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread John Fastabend
On 16-12-08 11:38 AM, Alexei Starovoitov wrote: > On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: >> From: John Fastabend >> Date: Wed, 07 Dec 2016 12:10:47 -0800 >> >>> This implements virtio_net for the mergeable buffers and big_packet >>> modes. I tested this with vhost_net runnin

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread Alexei Starovoitov
On Thu, Dec 08, 2016 at 02:17:02PM -0500, David Miller wrote: > From: John Fastabend > Date: Wed, 07 Dec 2016 12:10:47 -0800 > > > This implements virtio_net for the mergeable buffers and big_packet > > modes. I tested this with vhost_net running on qemu and did not see > > any issues. For testin

Re: [net-next PATCH v5 0/6] XDP for virtio_net

2016-12-08 Thread David Miller
From: John Fastabend Date: Wed, 07 Dec 2016 12:10:47 -0800 > This implements virtio_net for the mergeable buffers and big_packet > modes. I tested this with vhost_net running on qemu and did not see > any issues. For testing num_buf > 1 I added a hack to vhost driver > to only but 100 bytes per b

[net-next PATCH v5 0/6] XDP for virtio_net

2016-12-07 Thread John Fastabend
This implements virtio_net for the mergeable buffers and big_packet modes. I tested this with vhost_net running on qemu and did not see any issues. For testing num_buf > 1 I added a hack to vhost driver to only but 100 bytes per buffer. There are some restrictions for XDP to be enabled and work we