Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-06 Thread Jakub Kicinski
On Sun, 6 Sep 2020 21:23:37 +0200 Linus Walleij wrote: > On Sun, Sep 6, 2020 at 7:41 PM Jakub Kicinski wrote: > > On Sat, 5 Sep 2020 12:32:33 +0200 Linus Walleij wrote: > > > When removing a port from a VLAN we are just erasing the > > > member config for the VLAN, which is wrong: other ports >

Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-06 Thread Linus Walleij
On Sun, Sep 6, 2020 at 7:41 PM Jakub Kicinski wrote: > On Sat, 5 Sep 2020 12:32:33 +0200 Linus Walleij wrote: > > When removing a port from a VLAN we are just erasing the > > member config for the VLAN, which is wrong: other ports > > can be using it. > > > > Just mask off the port and only zero

Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 12:32:33 +0200 Linus Walleij wrote: > When removing a port from a VLAN we are just erasing the > member config for the VLAN, which is wrong: other ports > can be using it. > > Just mask off the port and only zero out the rest of the > member config once ports using of the VLAN

[net-next PATCH] net: dsa: rtl8366: Properly clear member config

2020-09-05 Thread Linus Walleij
When removing a port from a VLAN we are just erasing the member config for the VLAN, which is wrong: other ports can be using it. Just mask off the port and only zero out the rest of the member config once ports using of the VLAN are removed from it. Reported-by: Florian Fainelli Signed-off-by: