Re: [net-next] net: remove duplicate add_device_randomness() call

2017-05-17 Thread David Miller
From: Zhang Shengju Date: Wed, 17 May 2017 17:23:26 +0800 > Since register_netdevice() already call add_device_randomness() and > dev_set_mac_address() will call it after mac address change. > It's not necessary to call at device UP. > > Signed-off-by: Zhang Shengju __dev_open() can (at least

[net-next] net: remove duplicate add_device_randomness() call

2017-05-17 Thread Zhang Shengju
Since register_netdevice() already call add_device_randomness() and dev_set_mac_address() will call it after mac address change. It's not necessary to call at device UP. Signed-off-by: Zhang Shengju --- net/core/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/dev.c b/net/core/d

RE: [net-next] net: remove duplicate add_device_randomness() call

2017-05-04 Thread 张胜举
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, May 04, 2017 11:13 PM > To: zhangshen...@cmss.chinamobile.com > Cc: netdev@vger.kernel.org; eduma...@google.com > Subject: Re: [net-next] net: remove duplicate add_device_randomnes

Re: [net-next] net: remove duplicate add_device_randomness() call

2017-05-04 Thread David Miller
From: Zhang Shengju Date: Thu, 4 May 2017 11:40:42 +0800 > Since register_netdevice() already call add_device_randomness() and > dev_set_mac_address() will call it after mac address change. > It's not necessary to call at device UP. > > Signed-off-by: Zhang Shengju The net-next tree is closed

[net-next] net: remove duplicate add_device_randomness() call

2017-05-03 Thread Zhang Shengju
Since register_netdevice() already call add_device_randomness() and dev_set_mac_address() will call it after mac address change. It's not necessary to call at device UP. Signed-off-by: Zhang Shengju --- net/core/dev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/dev.c b/net/core/d