From: Zhang Shengju <zhangshen...@cmss.chinamobile.com> Date: Wed, 17 May 2017 17:23:26 +0800
> Since register_netdevice() already call add_device_randomness() and > dev_set_mac_address() will call it after mac address change. > It's not necessary to call at device UP. > > Signed-off-by: Zhang Shengju <zhangshen...@cmss.chinamobile.com> __dev_open() can (at least theroretically) do things which adjust the MAC address, and therefore the add_device_randomness() call is appropriate. And even if ->ndo_open() implementations do not do so currently, I do not want to prevent it from doing so. I am not applying this patch, sorry.
