Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-14 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Sagi Grimberg wrote: > > > Can you explain what do you mean by "subsystem"? I thought that the > > > subsystem would be the irq subsystem (which means you are the one to > > > provide > > > the needed input :) ) and the driver would pass in something > > > like msi_irq_ops to p

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-13 Thread Sagi Grimberg
Can you explain what do you mean by "subsystem"? I thought that the subsystem would be the irq subsystem (which means you are the one to provide the needed input :) ) and the driver would pass in something like msi_irq_ops to pci_alloc_irq_vectors() if it supports the driver requirements that yo

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Sagi Grimberg wrote: > > > > #1 Before the core tries to move the interrupt so it can veto > > > > the > > > > move if it cannot allocate new resources or whatever is > > > > required > > > > to operate after the move. > > > > > > What would the c

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-13 Thread Sagi Grimberg
Do you know if any exist? Would it make sense to have a survey to understand if anyone relies on it? From what I've seen so far, drivers that were converted simply worked with the non-managed facility and didn't have any special code for it. Perhaps Christoph can comment as he convert most of

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-13 Thread Thomas Gleixner
On Mon, 13 Nov 2017, Sagi Grimberg wrote: > > 3) Affinity override in managed mode > > > > Doable, but there are a couple of things to think about: > > I think that it will be good to shoot for (3). Given that there are > driver requirements I'd say that driver will expose up front if it can >

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-13 Thread Sagi Grimberg
Hi Thomas, What can be done with some time to work on? The managed mechanism consists of 3 pieces: 1) Vector spreading 2) Managed vector allocation, which becomes a guaranteed reservation in 4.15 due of the big rework of the vector management code. Non managed interrupts get a

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-10 Thread Thomas Gleixner
On Fri, 10 Nov 2017, Saeed Mahameed wrote: > Well, I can speak for mlx5 case or most of the network drivers, where > all of the queues associated with an interrupt, move with it, so i > don't think our current driver have this issue. I don't believe there > are network driver with fixed Per cpu re

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-09 Thread Saeed Mahameed
On Thu, 2017-11-09 at 22:42 +0100, Thomas Gleixner wrote: > Find below a summary of the technical details, implications and > options > > What can be done for 4.14? > > We basically have two options: Revert at the driver level or ship > as > is. > I think we all came to the consensus that t

[RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

2017-11-09 Thread Thomas Gleixner
Find below a summary of the technical details, implications and options What can be done for 4.14? We basically have two options: Revert at the driver level or ship as is. Even if we come up with a quick and dirty hack then it will be too late for proper testing before sunday. What can