Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-30 Thread David Rientjes
On Thu, 18 Jun 2015, Michal Hocko wrote: > That is to be discussed. Most allocations already express their interest > in memory reserves by __GFP_HIGH directly or by GFP_ATOMIC indirectly. > So maybe we do not need any additional flag here. There are not that > many ~__GFP_WAIT and most of them se

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Michal Hocko
On Thu 18-06-15 17:22:40, Vlastimil Babka wrote: > On 06/18/2015 04:43 PM, Michal Hocko wrote: > >On Thu 18-06-15 07:35:53, Eric Dumazet wrote: > >>On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: > >> > >>>Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the > >>>_current_ i

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Vlastimil Babka
On 06/18/2015 04:43 PM, Michal Hocko wrote: On Thu 18-06-15 07:35:53, Eric Dumazet wrote: On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the _current_ implementation of the allocator has this nasty and very subtle side e

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Michal Hocko
On Thu 18-06-15 07:35:53, Eric Dumazet wrote: > On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: > > > Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the > > _current_ implementation of the allocator has this nasty and very subtle > > side effect but that doesn't mean it s

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Eric Dumazet
On Thu, Jun 18, 2015 at 7:30 AM, Michal Hocko wrote: > Abusing __GFP_NO_KSWAPD is a wrong way to go IMHO. It is true that the > _current_ implementation of the allocator has this nasty and very subtle > side effect but that doesn't mean it should be abused outside of the mm > proper. Why shouldn'

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-18 Thread Michal Hocko
On Wed 17-06-15 16:02:59, David Rientjes wrote: > On Fri, 12 Jun 2015, Vlastimil Babka wrote: > > > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > > index 3cfff2a..41ec022 100644 > > > --- a/net/core/skbuff.c > > > +++ b/net/core/skbuff.c > > > @@ -4398,7 +4398,7 @@ struct sk_buff *alloc

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-17 Thread David Rientjes
On Fri, 12 Jun 2015, Vlastimil Babka wrote: > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > index 3cfff2a..41ec022 100644 > > --- a/net/core/skbuff.c > > +++ b/net/core/skbuff.c > > @@ -4398,7 +4398,7 @@ struct sk_buff *alloc_skb_with_frags(unsigned long > > header_len, > > > >

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-12 Thread Vlastimil Babka
On 06/12/2015 01:50 AM, Shaohua Li wrote: We saw excessive direct memory compaction triggered by skb_page_frag_refill. This causes performance issues and add latency. Commit 5640f7685831e0 introduces the order-3 allocation. According to the changelog, the order-3 allocation isn't a must-have but

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-11 Thread David Miller
From: Shaohua Li Date: Thu, 11 Jun 2015 16:50:48 -0700 > We saw excessive direct memory compaction triggered by skb_page_frag_refill. > This causes performance issues and add latency. Commit 5640f7685831e0 > introduces the order-3 allocation. According to the changelog, the order-3 > allocation i

Re: [RFC V3] net: don't wait for order-3 page allocation

2015-06-11 Thread Eric Dumazet
On Thu, 2015-06-11 at 16:50 -0700, Shaohua Li wrote: > We saw excessive direct memory compaction triggered by skb_page_frag_refill. > This causes performance issues and add latency. Commit 5640f7685831e0 > introduces the order-3 allocation. According to the changelog, the order-3 > allocation isn't

[RFC V3] net: don't wait for order-3 page allocation

2015-06-11 Thread Shaohua Li
We saw excessive direct memory compaction triggered by skb_page_frag_refill. This causes performance issues and add latency. Commit 5640f7685831e0 introduces the order-3 allocation. According to the changelog, the order-3 allocation isn't a must-have but to improve performance. But direct memory co