Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-23 Thread David Miller
From: Maninder Singh Date: Mon, 22 Jun 2015 12:39:16 +0530 > Remove handling of tx_ring in prb_setup_retire_blk_timer > for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring > and thus prb_setup_retire_blk_timer for zero tx_ring only. > > And also in functon init_prb_bdqc there i

[RFC PATCH v2] packet: remove handling of tx_ring

2015-06-22 Thread Maninder Singh
Remove handling of tx_ring in prb_setup_retire_blk_timer for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring and thus prb_setup_retire_blk_timer for zero tx_ring only. And also in functon init_prb_bdqc there is no usage of tx_ring. Thus removing tx_ring from init_prb_bdqc. Signe

Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-22 Thread Frans Klaver
ing tx_ring from init_prb_bdqc. > > net/packet/af_packet.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > Thanks > Maninder No, I didn't make myself clear enough, I'm afraid. The info about the different incarnations of your patch sho

Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-21 Thread Maninder Singh
Hi Frans, >> v1 = replace if()/BUG with BUG_ON() for tx_ring. >> >> v2 = > >I would keep this below the ---. There's little historical use for >this version information when it gets merged. > >> remove handling of tx_ring in prb_setup_retire_blk_timer >> for TPACKET_V3 because init_prb_bdqc is cal

Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-21 Thread Frans Klaver
On Mon, Jun 22, 2015 at 7:54 AM, Maninder Singh wrote: > v1 = replace if()/BUG with BUG_ON() for tx_ring. > > v2 = I would keep this below the ---. There's little historical use for this version information when it gets merged. > remove handling of tx_ring in prb_setup_retire_blk_timer > for TPA

[RFC PATCH v2] packet: remove handling of tx_ring

2015-06-21 Thread Maninder Singh
v1 = replace if()/BUG with BUG_ON() for tx_ring. v2 = remove handling of tx_ring in prb_setup_retire_blk_timer for TPACKET_V3 because init_prb_bdqc is called only for NULL tx_ring and thus prb_setup_retire_blk_timer for NULL tx_ring only. And also in funciton init_prb_bdqc there is no usage of t