Hi Frans, >> v1 = replace if()/BUG with BUG_ON() for tx_ring. >> >> v2 = > >I would keep this below the ---. There's little historical use for >this version information when it gets merged. > >> remove handling of tx_ring in prb_setup_retire_blk_timer >> for TPACKET_V3 because init_prb_bdqc is called only for NULL tx_ring >> and thus prb_setup_retire_blk_timer for NULL tx_ring only. > >I'd say tx_ring is false, rather than NULL. It's not a pointer (here). > > >> And also in funciton init_prb_bdqc there is no usage of tx_ring. > >s,funciton,function,
Thanks for feedback , please check below changelog if it looks ok, Then i will share updated patch:- v1 = replace if()/BUG with BUG_ON() for tx_ring. Signed-off-by: Maninder Singh <maninder...@samsung.com> Signed-off-by: Frans Klaver <franskla...@gmail.com> --- Changes in v2: Remove handling of tx_ring in prb_setup_retire_blk_timer for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring and thus prb_setup_retire_blk_timer for zero tx_ring only. And also in functon init_prb_bdqc there is no usage of tx_ring. Thus removing tx_ring from init_prb_bdqc. net/packet/af_packet.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) Thanks Maninder
