Re: [RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Russell King - ARM Linux admin
Hi Jonathan, A quick read through on the first review... On Mon, Jun 08, 2020 at 07:39:53PM +0100, Jonathan McDowell wrote: > +static int > +qca8k_phylink_mac_link_state(struct dsa_switch *ds, int port, > + struct phylink_link_state *state) > +{ > + struct qca8k_priv

Re: [RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Andrew Lunn
On Mon, Jun 08, 2020 at 07:39:53PM +0100, Jonathan McDowell wrote: > On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > > I'll go away and roll a v2 moving qca8k over to phylink and then using > > that to auto select the appropriate SGMII mode. Thanks for the feedback. > > Ok, ta

[RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Jonathan McDowell
On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > I'll go away and roll a v2 moving qca8k over to phylink and then using > that to auto select the appropriate SGMII mode. Thanks for the feedback. Ok, take 2. I've switched the driver over to phylink which has let me drop the need