On Mon, Jun 08, 2020 at 07:39:53PM +0100, Jonathan McDowell wrote:
> On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote:
> > I'll go away and roll a v2 moving qca8k over to phylink and then using
> > that to auto select the appropriate SGMII mode. Thanks for the feedback.
>
> Ok, take 2. I've switched the driver over to phylink which has let me
> drop the need for any device tree configuration; if we're a CPU port
> then we're in SGMII-PHY mode, otherwise we choose between SGMII-MAC +
> Base-X on what phylink tells us.
Hi Johnathan
Could you split this into two parts. One or more patches which
converts to phylink, and a patch which adds new functionality. If it
breaks, we then have a better idea what broke it.
Conversions to phylink are not easy to review because a lot of code
gets moved around. It sometimes helps if you can turn existing code
into helpers, rather than inline them.
Andrew
