Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

2017-03-09 Thread David Miller
From: David Howells Date: Thu, 09 Mar 2017 07:51:34 + > David Miller wrote: > >> I guess this is fine, but I think you can use one of the two "sk_padding" >> bits in struct sock instead of making the structure larger. > > It shouldn't make the structure larger since there's a hole in the s

Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

2017-03-08 Thread David Howells
David Miller wrote: > I guess this is fine, but I think you can use one of the two "sk_padding" > bits in struct sock instead of making the structure larger. It shouldn't make the structure larger since there's a hole in the structure: unsigned intsk_padding : 2,

Re: [RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

2017-03-08 Thread David Miller
From: David Howells Date: Mon, 06 Mar 2017 15:04:44 + > Fix the general case by: > > (1) Double up all the locking keys used in sockets so that one set are > used if the socket is created by userspace and the other set is used > if the socket is created by the kernel. > > (2) St

[RFC PATCH net] net: Work around lockdep limitation in sockets that use sockets

2017-03-06 Thread David Howells
Lockdep issues a circular dependency warning when AFS issues an operation through AF_RXRPC from a context in which the VFS/VM holds the mmap_sem. The theory lockdep comes up with is as follows: (1) If the pagefault handler decides it needs to read pages from AFS, it calls AFS with mmap_sem