Re: [Patch net-next] net_sched: remove the leftover cleanup_a()

2016-08-04 Thread Cong Wang
On Thu, Aug 4, 2016 at 5:10 AM, Jamal Hadi Salim wrote: > On 16-08-03 11:20 AM, Cong Wang wrote: >> >> On Wed, Aug 3, 2016 at 4:36 AM, Jamal Hadi Salim wrote: >>> >>> Cong, >>> >>> Improvement on the basic test as it no longer oopses, but: >>> here's a test that will oops: >> >> >> Make sure you

Re: [Patch net-next] net_sched: remove the leftover cleanup_a()

2016-08-04 Thread Jamal Hadi Salim
On 16-08-03 11:20 AM, Cong Wang wrote: On Wed, Aug 3, 2016 at 4:36 AM, Jamal Hadi Salim wrote: Cong, Improvement on the basic test as it no longer oopses, but: here's a test that will oops: Make sure you test this together with the other patch I sent (sorry I didn't number them), the other p

Re: [Patch net-next] net_sched: remove the leftover cleanup_a()

2016-08-03 Thread Cong Wang
On Wed, Aug 3, 2016 at 4:36 AM, Jamal Hadi Salim wrote: > Cong, > > Improvement on the basic test as it no longer oopses, but: > here's a test that will oops: Make sure you test this together with the other patch I sent (sorry I didn't number them), the other patch also fixed an oops. > > And b

Re: [Patch net-next] net_sched: remove the leftover cleanup_a()

2016-08-03 Thread Jamal Hadi Salim
Cong, Improvement on the basic test as it no longer oopses, but: here's a test that will oops: - # add action that will be shared for multi-flows sudo tc actions add action drop index 10 #add an action noone uses sudo tc actions add action ok index 12 # sudo tc actions

[Patch net-next] net_sched: remove the leftover cleanup_a()

2016-08-02 Thread Cong Wang
After refactoring tc_action into tcf_common, we no longer need to cleanup temporary "actions" in list, they are permanently stored in the hashtable. Reported-by: Jamal Hadi Salim Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/act_api.c | 22 +++--- 1 file changed,