Re: [Patch 1/6] IPSEC: core updates

2006-02-23 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Tue, 21 Feb 2006 08:31:49 -0500 > Ok. Patch attached against net-2617 > > Yoshfuji-san you should probably write a little doc that should be > available in the Doc/ directory. If we write this, please ask Andi Kleen to review it. His arch has the most proble

Re: [Patch 1/6] IPSEC: core updates

2006-02-21 Thread jamal
On Mon, 2006-20-02 at 15:05 -0800, David S. Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Mon, 20 Feb 2006 08:10:44 -0500 > > > Explain the rules to me: is it because the alignment in xfrm_usersa_id > > may change in the future? > > Alignment on x86 of u64 is different from x86_64 and i

Re: [Patch 1/6] IPSEC: core updates

2006-02-20 Thread David S. Miller
From: jamal <[EMAIL PROTECTED]> Date: Mon, 20 Feb 2006 08:10:44 -0500 > Explain the rules to me: is it because the alignment in xfrm_usersa_id > may change in the future? Alignment on x86 of u64 is different from x86_64 and ia64, so we must be extremely careful else we will have to translate thes

Re: [Patch 1/6] IPSEC: core updates

2006-02-19 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Mon, 20 Feb 2006 14:29:47 +0900 (JST) > > +struct xfrm_aevent_id { > > + __u32 flags; > > + struct xfrm_usersa_id sa_id; > > +}; > > + > > struct xfrm_userspi_info { > > struct xfrm_usersa_info i

Re: [Patch 1/6] IPSEC: core updates

2006-02-19 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 27 Jan 2006 08:05:23 -0500), jamal <[EMAIL PROTECTED]> says: > diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h > index 82fbb75..b54a129 100644 > --- a/include/linux/xfrm.h > +++ b/include/linux/xfrm.h : > @@ -235,6 +258,11 @@ struct xfrm_usersa_id

Re: [Patch 1/6] IPSEC: core updates

2006-02-01 Thread jamal
Hi Krisztian, On Tue, 2006-31-01 at 22:37 +0100, KOVACS Krisztian wrote: > Hi, > But what about leaving this alone for now, I think the very first step > should be something like OpenBSD's sasyncd, which absolutely does not > care about proper ISAKMP synchronization. We can think about thes

Re: [Patch 1/6] IPSEC: core updates

2006-01-31 Thread KOVACS Krisztian
Hi, On Monday 30 January 2006 22:33, jamal wrote: > > We implemented partial ISAKMP SA synchronization in racoon. That > Unfortunately this would also mean dependency on racoon. Is there any > other way to do it without having to change racoon? example the phase1 > scripts or racoonctl? > It

Re: [Patch 1/6] IPSEC: core updates

2006-01-30 Thread jamal
Olla, On Mon, 2006-30-01 at 15:33 +0100, KOVACS Krisztian wrote: > On Monday 30 January 2006 14.14, jamal wrote: [..] > We implemented partial ISAKMP SA synchronization in racoon. That way the > cookies, the shared secrets, etc. were synchronized to the slaves, so that > after failing over the

Re: [Patch 1/6] IPSEC: core updates

2006-01-30 Thread KOVACS Krisztian
Hi, On Monday 30 January 2006 14.14, jamal wrote: [...] > > To put it simple: I don't think PF_KEY is worth the hassle unless > > someone comes up with an open source software utilizing that interface. > > I agree. And if you look at something like sasyncd, it is obvious you > dont need it if

Re: [Patch 1/6] IPSEC: core updates

2006-01-30 Thread jamal
Olla Krisztian, Thanks for taking the time. On Sun, 2006-29-01 at 22:54 +0100, KOVACS Krisztian wrote: > Hi, > > On Saturday 28 January 2006 13:45, jamal wrote: [..] > I don't really like the idea of generating events unless explicitly > requested by the KM. Once a PF_KEY interface is in pl

Re: [Patch 1/6] IPSEC: core updates

2006-01-29 Thread KOVACS Krisztian
Hi, On Saturday 28 January 2006 13:45, jamal wrote: > > > +extern u32 sysctl_xfrm_aevent_etime; > > > +extern u32 sysctl_xfrm_aevent_rseqth; > > > > Why do we need these defaults? I'd rather see these be removed and > > just have the user-space KM always set the values (if it needs > > aevent).

Re: [Patch 1/6] IPSEC: core updates

2006-01-28 Thread jamal
On Sat, 2006-28-01 at 20:49 +1100, Herbert Xu wrote: > On Fri, Jan 27, 2006 at 08:05:23AM -0500, jamal wrote: > > +extern u32 sysctl_xfrm_aevent_on; > > I'd prefer for this to be automatically determined. Indeed, this is > a generic netlink problem. We want to be easily determine at run time >

Re: [Patch 1/6] IPSEC: core updates

2006-01-28 Thread Patrick McHardy
Herbert Xu wrote: > On Fri, Jan 27, 2006 at 08:05:23AM -0500, jamal wrote: > >>+extern u32 sysctl_xfrm_aevent_on; > > > I'd prefer for this to be automatically determined. Indeed, this is > a generic netlink problem. We want to be easily determine at run time > whether there are netlink socket

Re: [Patch 1/6] IPSEC: core updates

2006-01-28 Thread Herbert Xu
On Fri, Jan 27, 2006 at 08:05:23AM -0500, jamal wrote: > > the core changes Thanks for the patches Jamal. I agree with the basic idea. > +extern u32 sysctl_xfrm_aevent_on; I'd prefer for this to be automatically determined. Indeed, this is a generic netlink problem. We want to be easily de

[Patch 1/6] IPSEC: core updates

2006-01-27 Thread jamal
the core changes cheers, jamal This patch provides the core functionality needed for sync events for ipsec. Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]> --- include/linux/sysctl.h |3 ++ include/linux/xfrm.h | 30 include/net/xfrm.h | 33 +