Re: [PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Stephen Hemminger
On Wed, 9 Sep 2015 22:00:36 + Matthias Tafelmeier wrote: > >> +#define STATIC_ASSERT(COND, MSG) \ > >> +{ \ > >> + char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \ > >> + (void)STATIC_ASSERT##MSG[0];\ > >> +} > >

Re: [PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Matthias Tafelmeier
>> +#define STATIC_ASSERT(COND, MSG)\ >> +{ \ >> +char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \ >> +(void)STATIC_ASSERT##MSG[0];\ >> +} > > If you are going to introduce this, please use same convention >

Re: [PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Stephen Hemminger
On Wed, 9 Sep 2015 19:43:13 + Matthias Tafelmeier wrote: > +#define STATIC_ASSERT(COND, MSG) \ > +{\ > + char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \ > + (void)STATIC_ASSERT##MSG[0];\ > +} If you

[PATCH v6 02/10] ss: created formatters for json and hr

2015-09-09 Thread Matthias Tafelmeier
This patch creates a central formatter module that acts as a kind of switch. From there, more specific handler modules for the certain output formats are called. Up to now, humand readable and json do exist. That prepares ss for potential output format extensions in the future. With the help of su