On Aug 25 16:03, David Miller wrote:
> From: David Miller
> Date: Tue, 25 Aug 2015 15:59:21 -0700 (PDT)
>
> > From: Francois Romieu
> > Date: Wed, 26 Aug 2015 00:54:06 +0200
> >
> >>> Bringing the interface is brought down/up should not reset the
> >>> counters.
> >>
> >> Afaiks rtl8169_tc_off
On Aug 26 00:54, Francois Romieu wrote:
> David Miller :
> [...]
> > Your counter offsets should be read at probe time, not open time.
>
> It can be done but the "CmdRxEnb / rx traffic must be enabled" constraint
> will make it a major pita.
>
> Reading counter offsets at the end of open() natu
From: David Miller
Date: Tue, 25 Aug 2015 15:59:21 -0700 (PDT)
> From: Francois Romieu
> Date: Wed, 26 Aug 2015 00:54:06 +0200
>
>>> Bringing the interface is brought down/up should not reset the
>>> counters.
>>
>> Afaiks rtl8169_tc_offsets.inited in rtl8169_init_counter_offsets
>> takes care
From: Francois Romieu
Date: Wed, 26 Aug 2015 00:54:06 +0200
> David Miller :
> [...]
>> Your counter offsets should be read at probe time, not open time.
>
> It can be done but the "CmdRxEnb / rx traffic must be enabled" constraint
> will make it a major pita.
>
> Reading counter offsets at t
David Miller :
[...]
> Your counter offsets should be read at probe time, not open time.
It can be done but the "CmdRxEnb / rx traffic must be enabled" constraint
will make it a major pita.
Reading counter offsets at the end of open() naturally solves this
constraint (retentive error unwinding
From: Corinna Vinschen
Date: Mon, 24 Aug 2015 12:52:39 +0200
> The r8169 driver collects statistical information returned by
> @get_stats64 by counting them in the driver itself, even though many
> (but not all) of the values are already collected by tally counters
> (TCs) in the NIC. Some of th
The r8169 driver collects statistical information returned by
@get_stats64 by counting them in the driver itself, even though many
(but not all) of the values are already collected by tally counters
(TCs) in the NIC. Some of these TC values are not returned by
@get_stats64. Especially the receive
