From: Francois Romieu <rom...@fr.zoreil.com> Date: Wed, 26 Aug 2015 00:54:06 +0200
> David Miller <da...@davemloft.net> : > [...] >> Your counter offsets should be read at probe time, not open time. > > It can be done but the "CmdRxEnb / rx traffic must be enabled" constraint > will make it a major pita. > > Reading counter offsets at the end of open() naturally solves this > constraint (retentive error unwinding in opne() stops being completely > trivial though :o/ ). So you can manage whether you've done the "once per device probe" counter reset, and act upon it at the end of ->open(). >> Bringing the interface is brought down/up should not reset the >> counters. > > Afaiks rtl8169_tc_offsets.inited in rtl8169_init_counter_offsets > takes care of it: it's set during the first open() after probe(). Ok, then it's fine. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
