Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-23 Thread Raju Lakkaraju
Hi Rob, Thank you for code review comments. On Tue, Feb 21, 2017 at 10:42:38AM -0600, Rob Herring wrote: > EXTERNAL EMAIL > > > > Do i need to change from "vsc8531, led-0-mode" to "mscc, led-0-mode" > > Is this your suggestion? > > Well, there shouldn't be a space there, but yess, mscc is the

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-21 Thread Rob Herring
On Thu, Feb 16, 2017 at 3:06 AM, Raju Lakkaraju wrote: > Hi Rob, > > On Wed, Feb 15, 2017 at 10:45:40AM -0600, Rob Herring wrote: >> EXTERNAL EMAIL >> >> >> On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote: >> > From: Raju Lakkaraju >> > >> > + Default value is

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-16 Thread Andrew Lunn
On Thu, Feb 16, 2017 at 02:36:48PM +0530, Raju Lakkaraju wrote: > Hi Rob, > > On Wed, Feb 15, 2017 at 10:45:40AM -0600, Rob Herring wrote: > > EXTERNAL EMAIL > > > > > > On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote: > > > From: Raju Lakkaraju > > > > > > +

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-16 Thread Raju Lakkaraju
Hi Rob, On Wed, Feb 15, 2017 at 10:45:40AM -0600, Rob Herring wrote: > EXTERNAL EMAIL > > > On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > + Default value is VSC8531_LINK_1000_ACTIVITY (1). > > +- vsc8531,led-1-mode : LED m

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-15 Thread Rob Herring
On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote: > From: Raju Lakkaraju > > LED Mode: > Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different > status information that can be selected by setting LED mode. > > LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, l

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-08 Thread David Miller
From: Raju Lakkaraju Date: Tue, 7 Feb 2017 19:10:26 +0530 > From: Raju Lakkaraju > > LED Mode: > Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different > status information that can be selected by setting LED mode. > > LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, led-1

[PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-07 Thread Raju Lakkaraju
From: Raju Lakkaraju LED Mode: Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different status information that can be selected by setting LED mode. LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, led-1-mode) get from Device Tree. Signed-off-by: Raju Lakkaraju --- Change se