On Thu, Feb 16, 2017 at 3:06 AM, Raju Lakkaraju <raju.lakkar...@microsemi.com> wrote: > Hi Rob, > > On Wed, Feb 15, 2017 at 10:45:40AM -0600, Rob Herring wrote: >> EXTERNAL EMAIL >> >> >> On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote: >> > From: Raju Lakkaraju <raju.lakkar...@microsemi.com> >> > >> > + Default value is VSC8531_LINK_1000_ACTIVITY (1). >> > +- vsc8531,led-1-mode : LED mode. Specify how the LED[1] should behave. >> >> You failed to address my comment on v2. vsc8531 is not a vendor prefix. >> Please fix in a new patch since David already applied it. >> > > Accpeted my fault. i missed your comment. > Do i need to change from "vsc8531, led-0-mode" to "mscc, led-0-mode" > Is this your suggestion?
Well, there shouldn't be a space there, but yess, mscc is the prefix. Read my original comments. I also suggested combining this to a single property. Rob
