On Fri, 6 Nov 2020 09:24:48 +0100 Jiri Benc wrote:
> On Thu, 5 Nov 2020 14:57:13 -0800, Jakub Kicinski wrote:
> > If you're saying the driver message would still be there if
> > verification or translation failed that's perfectly fine, we
> > can definitely adjust the test. But some check that dri
On Thu, 5 Nov 2020 13:22:12 -0800, Andrii Nakryiko wrote:
> test_progs is the only test runner that's run continuously on every
> patch. libbpf CI also runs test_maps and test_verifier. All the other
> test binaries/scripts rely on humans to not forget about them. Which
> works so-so, as you can se
On Thu, 5 Nov 2020 14:57:13 -0800, Jakub Kicinski wrote:
> If you're saying the driver message would still be there if
> verification or translation failed that's perfectly fine, we
> can definitely adjust the test. But some check that driver
> message reporting is working is needed, don't just r
On Thu, 5 Nov 2020 14:41:12 -0800 Andrii Nakryiko wrote:
> On Thu, Nov 5, 2020 at 1:53 PM Jakub Kicinski wrote:
> > On Thu, 5 Nov 2020 13:22:12 -0800 Andrii Nakryiko wrote:
> > > Should we just drop check_verifier_log() checks?
> >
> > Drivers only print error messages when something goes wron
On Thu, Nov 5, 2020 at 1:53 PM Jakub Kicinski wrote:
>
> On Thu, 5 Nov 2020 13:22:12 -0800 Andrii Nakryiko wrote:
> > On Thu, Nov 5, 2020 at 8:02 AM Jiri Benc wrote:
> > > On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote:
> > > > To make BPF verifier verbose log more releavant and easier
On Thu, 5 Nov 2020 13:22:12 -0800 Andrii Nakryiko wrote:
> On Thu, Nov 5, 2020 at 8:02 AM Jiri Benc wrote:
> > On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote:
> > > To make BPF verifier verbose log more releavant and easier to use to debug
> > > verification failures, "pop" parts of l
On Thu, Nov 5, 2020 at 8:02 AM Jiri Benc wrote:
>
> On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote:
> > To make BPF verifier verbose log more releavant and easier to use to debug
> > verification failures, "pop" parts of log that were successfully verified.
> > This has effect of leavin
On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote:
> To make BPF verifier verbose log more releavant and easier to use to debug
> verification failures, "pop" parts of log that were successfully verified.
> This has effect of leaving only verifier logs that correspond to code branches
> tha
