On Thu, 23 Apr 2020 12:58:50 -0700, Andrii Nakryiko wrote: > To make BPF verifier verbose log more releavant and easier to use to debug > verification failures, "pop" parts of log that were successfully verified. > This has effect of leaving only verifier logs that correspond to code branches > that lead to verification failure, which in practice should result in much > shorter and more relevant verifier log dumps. This behavior is made the > default behavior and can be overriden to do exhaustive logging by specifying > BPF_LOG_LEVEL2 log level.
This patch broke the test_offload.py selftest: [...] Test TC offloads work... FAIL: Missing or incorrect message from netdevsim in verifier log [...] The selftest expects to receive "[netdevsim] Hello from netdevsim!" in the log (coming from nsim_bpf_verify_insn) but that part of the log is cleared by bpf_vlog_reset added by this patch. How can this be fixed? The log level 1 comes from the "verbose" keyword passed to tc, I don't think it should be increased to 2. On a related note, the selftest had to start failing after this commit. It's a bit surprising it did not get caught, is there a bug somewhere in the test matrix? Thanks, Jiri
