Re: [PATCH v2 net-next] net: fix GSO for SG-enabled devices.

2021-01-19 Thread Jakub Kicinski
On Wed, 20 Jan 2021 10:17:44 +0800 Xin Long wrote: > On Wed, Jan 20, 2021 at 12:57 AM Paolo Abeni wrote: > > > > The commit dbd50f238dec ("net: move the hsize check to the else > > block in skb_segment") introduced a data corruption for devices > > supporting scatter-gather. > > > > The problem bo

Re: [PATCH v2 net-next] net: fix GSO for SG-enabled devices.

2021-01-19 Thread Xin Long
On Wed, Jan 20, 2021 at 12:57 AM Paolo Abeni wrote: > > The commit dbd50f238dec ("net: move the hsize check to the else > block in skb_segment") introduced a data corruption for devices > supporting scatter-gather. > > The problem boils down to signed/unsigned comparison given > unexpected results

[PATCH v2 net-next] net: fix GSO for SG-enabled devices.

2021-01-19 Thread Paolo Abeni
The commit dbd50f238dec ("net: move the hsize check to the else block in skb_segment") introduced a data corruption for devices supporting scatter-gather. The problem boils down to signed/unsigned comparison given unexpected results: if signed 'hsize' is negative, it will be considered greater tha