On Wed, 20 Jan 2021 10:17:44 +0800 Xin Long wrote:
> On Wed, Jan 20, 2021 at 12:57 AM Paolo Abeni <pab...@redhat.com> wrote:
> >
> > The commit dbd50f238dec ("net: move the hsize check to the else
> > block in skb_segment") introduced a data corruption for devices
> > supporting scatter-gather.
> >
> > The problem boils down to signed/unsigned comparison given
> > unexpected results: if signed 'hsize' is negative, it will be
> > considered greater than a positive 'len', which is unsigned.
> >
> > This commit addresses resorting to the old checks order, so that
> > 'hsize' never has a negative value when compared with 'len'.
> >
> > v1 -> v2:
> > - reorder hsize checks instead of explicit cast (Alex)
> >
> > Bisected-by: Matthieu Baerts <matthieu.bae...@tessares.net>
> > Fixes: dbd50f238dec ("net: move the hsize check to the else block in
> > skb_segment")
> > Signed-off-by: Paolo Abeni <pab...@redhat.com>
> Reviewed-by: Xin Long <lucien....@gmail.com>
I'm hitting this as well, so applied, thanks!
> > ---
> Reviewed-by: Xin Long <lucien....@gmail.com>
One review tag is enough ;) apparently patchwork doesn't know to dedup
them :S
