Re: [PATCH v2] net: dsa: microchip: look for phy-mode in port nodes

2020-09-07 Thread Andrew Lunn
On Mon, Sep 07, 2020 at 08:15:33AM +0200, Helmut Grohne wrote: > Hi Andrew, > > On Fri, Sep 04, 2020 at 03:52:55PM +0200, Andrew Lunn wrote: > > > + dev_warn(dev->dev, > > > + "Using legacy switch \"phy-mode\" missing on > > > port %d node. Please update y

Re: [PATCH v2] net: dsa: microchip: look for phy-mode in port nodes

2020-09-06 Thread Helmut Grohne
Hi Andrew, On Fri, Sep 04, 2020 at 03:52:55PM +0200, Andrew Lunn wrote: > > + dev_warn(dev->dev, > > +"Using legacy switch \"phy-mode\" missing on > > port %d node. Please update your device tree.\n", This is inside ksz8795_port_setup. > That messag

Re: [PATCH v2] net: dsa: microchip: look for phy-mode in port nodes

2020-09-04 Thread Andrew Lunn
> + dev_warn(dev->dev, > + "Using legacy switch \"phy-mode\" missing on > port %d node. Please update your device tree.\n", That message seems mangled. > + if (!p->interface) { > + if (dev->compat_in

Re: [PATCH v2] net: dsa: microchip: look for phy-mode in port nodes

2020-09-04 Thread Alexandre Belloni
On 04/09/2020 10:14:42+0200, Helmut Grohne wrote: > Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode > property should be specified on port nodes. However, the microchip > drivers read it from the switch node. > > Let the driver use the per-port property and fall back to th

[PATCH v2] net: dsa: microchip: look for phy-mode in port nodes

2020-09-04 Thread Helmut Grohne
Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode property should be specified on port nodes. However, the microchip drivers read it from the switch node. Let the driver use the per-port property and fall back to the old location with a warning. Fix in-tree users. Signed-o