Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-18 Thread David Miller
From: Bryan Whitehead Date: Mon, 17 Dec 2018 16:44:50 -0500 > The LAN7431 uses an external phy, and it can be found anywhere in > the phy address space. This patch uses phy address 1 for LAN7430 > only. And searches all addresses otherwise. > > Signed-off-by: Bryan Whitehead Applied, thanks Br

Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-18 Thread Andrew Lunn
On Tue, Dec 18, 2018 at 04:41:20PM +, bryan.whiteh...@microchip.com wrote: > > > - /* set to internal PHY id */ > > > - adapter->mdiobus->phy_mask = ~(u32)BIT(1); > > > + if ((adapter->csr.id_rev & ID_REV_ID_MASK_) == > > ID_REV_ID_LAN7430_) > > > + /* LAN7430 uses internal phy at addre

RE: [PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-18 Thread Bryan.Whitehead
> > - /* set to internal PHY id */ > > - adapter->mdiobus->phy_mask = ~(u32)BIT(1); > > + if ((adapter->csr.id_rev & ID_REV_ID_MASK_) == > ID_REV_ID_LAN7430_) > > + /* LAN7430 uses internal phy at address 1 */ > > + adapter->mdiobus->phy_mask = ~(u32)BIT(1); > > Hi Bryan

Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-18 Thread Andrew Lunn
On Mon, Dec 17, 2018 at 04:44:50PM -0500, Bryan Whitehead wrote: > The LAN7431 uses an external phy, and it can be found anywhere in > the phy address space. This patch uses phy address 1 for LAN7430 > only. And searches all addresses otherwise. > > Signed-off-by: Bryan Whitehead > --- > drivers

[PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-17 Thread Bryan Whitehead
The LAN7431 uses an external phy, and it can be found anywhere in the phy address space. This patch uses phy address 1 for LAN7430 only. And searches all addresses otherwise. Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_main.c | 5 +++-- 1 file changed, 3 insertions(