> > - /* set to internal PHY id */ > > - adapter->mdiobus->phy_mask = ~(u32)BIT(1); > > + if ((adapter->csr.id_rev & ID_REV_ID_MASK_) == > ID_REV_ID_LAN7430_) > > + /* LAN7430 uses internal phy at address 1 */ > > + adapter->mdiobus->phy_mask = ~(u32)BIT(1); > > Hi Bryan > > Does LAN7430 have an external MDIO bus as well as the internal one? Is > there a possibility for a PHY at address 0? If not, you can probably just not > have a mask at all. > > Andrew
Hi Andrew, The LAN7430 does not have an external MDIO bus. And there is no possibility for a PHY at address 0. The reason I kept the mask for LAN7430 case is to reduce effort in finding the phy. Since Linux will scan all addresses in that case unnecessarily. But I have tested your suggestion and it does work without a mask. So I'm fine either way. If you prefer I do not use a mask for LAN7430 case, then let me know and I will submit a new patch version. Bryan
