On Fri, Mar 24, 2017 at 02:57:41PM +0100, Jonas Bonn wrote:
> On 03/24/2017 11:41 AM, Pablo Neira Ayuso wrote:
> >On Fri, Mar 24, 2017 at 10:33:56AM +0100, Jonas Bonn wrote:
> >>Changes since v2:
> >>
> >>* Move #define of legacy netlink attribute into enum
> >>* Added note to commit message about
On 03/24/2017 11:41 AM, Pablo Neira Ayuso wrote:
On Fri, Mar 24, 2017 at 10:33:56AM +0100, Jonas Bonn wrote:
Changes since v2:
* Move #define of legacy netlink attribute into enum
* Added note to commit message about load-testing use-case
* Ack from Pablo
Thanks a lot Jonas!
David, please app
Hi Harald,
On 03/24/2017 11:15 AM, Harald Welte wrote:
Hi Jonas,
looks fine to me, but I haven't tested it. Did you manually test it
using the extended libgtpnl + tools?
I have tested it against your libgtpnl branch laforge/sgsn-role.
Creating an interface with tools/gtp-link works fine.
On 03/24/2017 01:15 PM, Harald Welte wrote:
looks fine to me, but I haven't tested it. Did you manually test it
using the extended libgtpnl + tools?
Also, in code like this:
+ if (gtp->role == GTP_ROLE_SGSN) {
+ pctx = ipv4_pdp_find(gtp, iph->saddr);
+ } else {
I th
On Fri, Mar 24, 2017 at 11:15:25AM +0100, Harald Welte wrote:
> Hi Jonas,
>
> looks fine to me, but I haven't tested it. Did you manually test it
> using the extended libgtpnl + tools?
>
> Also, in code like this:
>
> + if (gtp->role == GTP_ROLE_SGSN) {
> + pctx = ipv4_pdp_f
Hi Jonas,
looks fine to me, but I haven't tested it. Did you manually test it
using the extended libgtpnl + tools?
Also, in code like this:
+ if (gtp->role == GTP_ROLE_SGSN) {
+ pctx = ipv4_pdp_find(gtp, iph->saddr);
+ } else {
I think general Linux kernel coding styl
On Fri, Mar 24, 2017 at 10:33:56AM +0100, Jonas Bonn wrote:
> Changes since v2:
>
> * Move #define of legacy netlink attribute into enum
> * Added note to commit message about load-testing use-case
> * Ack from Pablo
Thanks a lot Jonas!
David, please apply. Thanks!
Changes since v2:
* Move #define of legacy netlink attribute into enum
* Added note to commit message about load-testing use-case
* Ack from Pablo
Jonas Bonn (2):
gtp: rename SGSN netlink attribute
gtp: support SGSN-side tunnels
drivers/net/gtp.c| 63
